From 2fbd04103a1807efd7378a3ee9c60e7974ccb606 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 21 Dec 2015 12:24:46 +0000 Subject: [PATCH] Bug 15367: Do not display repeatable patron attributes in the batch patron modification The repeatable patron attributes are not correctly managed and can cause data lost. To avoid that, the easier way is not to display them in the batch patron modification tool. This should be implemented, as a new enhancement. Test plan: Create some patron attributes, some should be repeatable. Use the batch patron modification tool to modify patrons. With this patch, the patron attributes marked as repeatable won't be display anymore. Signed-off-by: Bernardo Gonzalez Kriegel Works as described, no koha-qa errors Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com (cherry picked from commit 9030800e78ad7de868e1c5fa4c9fd469660e6e5d) Signed-off-by: Julian Maurice --- tools/modborrowers.pl | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/modborrowers.pl b/tools/modborrowers.pl index 71588c02d3..f88581fbd2 100755 --- a/tools/modborrowers.pl +++ b/tools/modborrowers.pl @@ -107,6 +107,9 @@ if ( $op eq 'show' ) { my $patron_categories = C4::Members::GetBorrowercategoryList; for ( values %$patron_attribute_types ) { my $attr_type = C4::Members::AttributeTypes->fetch( $_->{code} ); + # TODO Repeatable attributes are not correctly managed and can cause data lost. + # This should be implemented. + next if $attr_type->{repeatable}; my $options = $attr_type->authorised_value_category ? GetAuthorisedValues( $attr_type->authorised_value_category ) : undef; -- 2.20.1