From 365ae9aa3cc216d0e9cadfbf3a7da92afbdfec7e Mon Sep 17 00:00:00 2001 From: Natasha Date: Mon, 18 Jan 2016 22:59:03 +0000 Subject: [PATCH] Bug 14538: editing perl doc for CalcFine To Test: Read perldoc C4/Overdues.pm Confirm that it says CalcFine returns four values and that rest of the documentation is correct NOTE: only a little visual ugliness, but definitely an improvement. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Jesse Weaver (cherry picked from commit f1bbc3d2a1c177847f7d34c9d2be771bd5fa03e8) Signed-off-by: Julian Maurice --- C4/Overdues.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/C4/Overdues.pm b/C4/Overdues.pm index 72c0704434..1827206144 100644 --- a/C4/Overdues.pm +++ b/C4/Overdues.pm @@ -204,7 +204,7 @@ sub checkoverdues { =head2 CalcFine - ($amount, $chargename, $daycounttotal) = &CalcFine($item, + ($amount, $chargename, $units_minus_grace, $chargeable_units) = &CalcFine($item, $categorycode, $branch, $start_dt, $end_dt ); @@ -236,10 +236,10 @@ C<$amount> is the fine owed by the patron (see above). C<$chargename> is the chargename field from the applicable record in the categoryitem table, whatever that is. -C<$unitcount> is the number of chargeable units (days between start and end dates, Calendar adjusted where needed, -minus any applicable grace period, or hours) +C<$units_minus_grace> is the number of chargeable units minus the grace period -FIXME - What is chargename supposed to be ? +C<$chargeable_units> is the number of chargeable units (days between start and end dates, Calendar adjusted where needed, +minus any applicable grace period, or hours) FIXME: previously attempted to return C<$message> as a text message, either "First Notice", "Second Notice", or "Final Notice". But CalcFine never defined any value. -- 2.20.1