From 38a6d9eeb6ffacd8406753dac4f5cd96702b330c Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 22 Dec 2017 11:20:13 +0100 Subject: [PATCH] Bug 19200: (QA follow-up) Simplify call to GetBasketAsCSV If no profile_id is passed, GetBasketAsCSV will fallback to default itself. No need to make the distinction in basket.pl. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens --- acqui/basket.pl | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/acqui/basket.pl b/acqui/basket.pl index 8df5f8b6ea..92fae60a0a 100755 --- a/acqui/basket.pl +++ b/acqui/basket.pl @@ -171,13 +171,7 @@ if ( $op eq 'delete_confirm' ) { -attachment => 'basket' . $basket->{'basketno'} . '.csv', ); my $csv_profile_id = $query->param('csv_profile'); - if (defined $csv_profile_id) { - # using a csv profile - print GetBasketAsCSV(scalar $query->param('basketno'), $query, $csv_profile_id); - } else { - # using default - print GetBasketAsCSV(scalar $query->param('basketno'), $query); - } + print GetBasketAsCSV( scalar $query->param('basketno'), $query, $csv_profile_id ); # if no csv_profile_id passed, using default rows exit; } elsif ($op eq 'email') { my $err = eval { -- 2.39.5