From 47caf69a469cb48ef18754d2e3bf077e5e882aa4 Mon Sep 17 00:00:00 2001 From: Chloe Date: Thu, 21 Jan 2016 23:47:42 +0000 Subject: [PATCH] Bug 12045 - Transfer impossible if barcode includes spaces have changed the code which strips the white space to only remove the leading and trailing white space instead To Test- 1- go to circulation -> transfer 2- attempt to tranfer an item where the barcode has a space in the middle of it 3- it should fail 4- apply patch 5- try again 6- it should work NOTE: I purposefully added: die "($barcode)"; Before, all spaces were removed. ' white space ' became '(whitespace)' After, only external spaces were remove ' white space ' became '(white space)' Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Brendan A Gallagher --- circ/branchtransfers.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/circ/branchtransfers.pl b/circ/branchtransfers.pl index 454fbefd30..a826289b65 100755 --- a/circ/branchtransfers.pl +++ b/circ/branchtransfers.pl @@ -108,8 +108,8 @@ elsif ( $request eq 'KillReserved' ) { my @trsfitemloop; my $transfered; my $barcode = $query->param('barcode'); -# strip whitespace -defined $barcode and $barcode =~ s/\s*//g; # FIXME: barcodeInputFilter +# remove leading/trailing whitespace +defined $barcode and $barcode =~ s/^\s*|\s*$//g; # FIXME: barcodeInputFilter # warn "barcode : $barcode"; if ($barcode) { -- 2.39.5