From 584059a9b8947aa531ad21a04e23b5ebac6ab5a1 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Mon, 28 Mar 2016 20:01:30 +0000 Subject: [PATCH] Bug 15682 - Merging records from cataloguing search only allows to merge 2 records To test: 1 - Perform a cataloging search 2 - Attempt to merge 0 results - should fail 3 - Attempt to merge 1 resutls - should fail 4 - Attempt to merge 2 results - should succeed 5 - Attempt to merge 3 results - should succeed 6 - Test any other amount of records and if more than 1 it should succeed **Note: On shelves.pl you can merge a single record. I think that is incorrect so made this only work for 2. Will add a followup to fix shelves.pl Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher (cherry picked from commit 8f1e5ad95fd78cbf09028e3d2dfe0b2b77d4dd21) Signed-off-by: Julian Maurice --- .../prog/en/modules/cataloguing/addbooks.tt | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt index 95b84dcded..f14cc40ac2 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt @@ -51,11 +51,15 @@ */ function MergeItems() { var checkboxes = $("input:checkbox:checked"); - var nbCheckbox = checkboxes.length; - if (nbCheckbox != 2) { - alert(_("Two records must be selected for merging.")); + if (checkboxes.length < 2) { + alert(_("At least two records must be selected for merging.")); } else { - location.href='/cgi-bin/koha/cataloguing/merge.pl?biblionumber=' + checkboxes[0].value + '&biblionumber=' + checkboxes[1].value; + var params = []; + $(checkboxes).each(function() { + params.push('biblionumber=' + $(this).val()); + }); + var url = '/cgi-bin/koha/cataloguing/merge.pl?' + params.join('&'); + location.href = url; } return false; } -- 2.20.1