From 5ac32b4d11383356405ea76f26751db09cf90231 Mon Sep 17 00:00:00 2001 From: Galen Charlton Date: Wed, 21 Aug 2013 16:29:18 +0000 Subject: [PATCH] Bug 10761: (follow-up) remove inadvertant dependence on Perl 5.14 As with commit 8f933bc04, Perl 5.14's support for array and hash container functions accepting hashrefs and arrayrefs is a syntax error in Perl 5.10. To test: Verify that t/db_dependent/Reports_Guided.t passes when run under a Perl version older than 5.14. Signed-off-by: Galen Charlton --- t/db_dependent/Reports_Guided.t | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/t/db_dependent/Reports_Guided.t b/t/db_dependent/Reports_Guided.t index 01cc66c0b7..273ee844f1 100755 --- a/t/db_dependent/Reports_Guided.t +++ b/t/db_dependent/Reports_Guided.t @@ -28,7 +28,7 @@ $dbh->do(q|DELETE FROM saved_sql|); #Start tests #Test save_report -my $count = scalar( keys get_saved_reports() ); +my $count = scalar( @{ get_saved_reports() } ); is( $count, 0, "There is no report" ); my @report_ids; @@ -51,7 +51,7 @@ like( $report_ids[0], '/^\d+$/', "Save_report returns an id for first" ); like( $report_ids[1], '/^\d+$/', "Save_report returns an id for second" ); like( $report_ids[2], '/^\d+$/', "Save_report returns an id for third" ); -is( scalar( keys get_saved_reports() ), +is( scalar( @{ get_saved_reports() } ), $count, "$count reports have been added" ); #Test delete_report @@ -60,12 +60,12 @@ is (delete_report(),undef, "Without id delete_report returns undef"); is( delete_report( $report_ids[0] ), 1, "report 1 is deleted" ); $count--; -is( scalar( keys get_saved_reports() ), $count, "Report1 has been deleted" ); +is( scalar( @{ get_saved_reports() } ), $count, "Report1 has been deleted" ); is( delete_report( $report_ids[1], $report_ids[2] ), 2, "report 2 and 3 are deleted" ); $count -= 2; -is( scalar( keys get_saved_reports() ), +is( scalar( @{ get_saved_reports() } ), $count, "Report2 and report3 have been deleted" ); #End transaction -- 2.20.1