From 6a2e6abb27f34f7d5557d77e9ef7fbf7ec740072 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Tue, 19 Jan 2016 11:36:44 -0500 Subject: [PATCH] Bug 14193 - Accessibility: Searching patrons using the alphabetic index doesn't work Using a mouse to click on the alphabetic index letters works even though the anchor markup doesn't contain an href attribute. However you can't tab to them using the keyboard, and I assume the issue with screen readers is related. This patch adds a dummy href attribute and a class-based click handler so that we can get rid of the "onclick" attribute in the markup. To test, apply the patch and visit the "Patrons" section. 1. Use the tab key to move the focus to one of the alphabet links. 2. Hit "Enter" and confirm that the search is performed correctly. 3. Click any of the alphabet links and confirm that clicking works as well. 4. View the details of any patron and click the "Add child" button. 5. In the "Guarantor information" section click the "Change" button. 6. In the search popup, use the tab key to move the focus to one of the alphabet links. 2. Hit "Enter" and confirm that the search is performed correctly. 3. Click any of the alphabet links and confirm that clicking works as well. Signed-off-by: Briana Signed-off-by: Katrin Fischer Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com (cherry picked from commit 6d6b2078c061c63db762d1ceff45d0eb7e391f02) Signed-off-by: Julian Maurice --- .../intranet-tmpl/prog/en/modules/common/patron_search.tt | 6 +++++- koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt index 0a50e83a21..20af6d064a 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt @@ -96,6 +96,10 @@ $(document).ready(function(){ })); $("#searchform").on('submit', filter); + $(".filterByLetter").on("click",function(e){ + e.preventDefault(); + filterByFirstLetterSurname($(this).text()); + }); }); function filter() { @@ -197,7 +201,7 @@ function filterByFirstLetterSurname(letter) {
Browse by last name: [% FOREACH letter IN alphabet.split(' ') %] - [% letter %] + [% letter %] [% END %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt index 49971b7f69..a0a47cc56d 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt @@ -93,6 +93,10 @@ $(document).ready(function() { }); return true; }); + $(".filterByLetter").on("click",function(e){ + e.preventDefault(); + filterByFirstLetterSurname($(this).text()); + }); }); var dtMemberResults; @@ -328,7 +332,7 @@ function filterByFirstLetterSurname(letter) {
Browse by last name: [% FOREACH letter IN alphabet.split(' ') %] - [% letter %] + [% letter %] [% END %]
-- 2.39.5