From 6e7a795d1981ddb47f67002e61ebac5eecf9ea90 Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Thu, 16 May 2019 16:55:16 +0100 Subject: [PATCH] Bug 22917: Fix a typo in an output_pref call Due to a type in a call to output_pref (datenonly vs dateonly) we were comparing logactions within a minutes accuracy. Counting the logs for the day would be sufficient for the test ;) Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens (cherry picked from commit 04d990c71d34d0c44999cfdf80e8379959d14de8) Signed-off-by: Martin Renvoize --- t/db_dependent/Circulation.t | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t index 164088d274..156be69c0b 100755 --- a/t/db_dependent/Circulation.t +++ b/t/db_dependent/Circulation.t @@ -2824,7 +2824,7 @@ subtest 'AddRenewal and AddIssuingCharge tests' => sub { AddIssue( $patron->unblessed, $item->barcode ); t::lib::Mocks::mock_preference( 'RenewalLog', 0 ); - my $date = output_pref( { dt => dt_from_string(), datenonly => 1, dateformat => 'iso' } ); + my $date = output_pref( { dt => dt_from_string(), dateonly => 1, dateformat => 'iso' } ); my $old_log_size = scalar( @{ GetLogs( $date, $date, undef, ["CIRCULATION"], ["RENEWAL"] ) } ); AddRenewal( $patron->id, $item->id, $library->id ); my $new_log_size = scalar( @{ GetLogs( $date, $date, undef, ["CIRCULATION"], ["RENEWAL"] ) } ); @@ -2835,7 +2835,7 @@ subtest 'AddRenewal and AddIssuingCharge tests' => sub { unlike ( $checkouts->next->lastreneweddate, qr/00:00:00/, 'AddRenewal should set the renewal date with the time part'); t::lib::Mocks::mock_preference( 'RenewalLog', 1 ); - $date = output_pref( { dt => dt_from_string(), datenonly => 1, dateformat => 'iso' } ); + $date = output_pref( { dt => dt_from_string(), dateonly => 1, dateformat => 'iso' } ); $old_log_size = scalar( @{ GetLogs( $date, $date, undef, ["CIRCULATION"], ["RENEWAL"] ) } ); AddRenewal( $patron->id, $item->id, $library->id ); $new_log_size = scalar( @{ GetLogs( $date, $date, undef, ["CIRCULATION"], ["RENEWAL"] ) } ); -- 2.39.2