From 9452c84a9a3df786233dfad3ff7df912d3bfdf82 Mon Sep 17 00:00:00 2001 From: Ian Walls Date: Tue, 18 Oct 2011 20:17:17 -0400 Subject: [PATCH] Bug 7061: unnecessary global variables declared in C4::SQLHelper Removes $tablename and $hash from global scope of C4/SQLHelper.pm. They are never used; all instances of $table are locally scoped to the subroutines, and $hash is never used. This may help with persistance; if not, it's at least a bit of trivial cleanup. To test: 1. Search for a patron 2. Create a Contract in Acquisitions 3. Modify that Contract 4. Delete that Contract All instances should return error free. This checks the subroutines of SQLHelper Signed-off-by: Nicole C. Engard Signed-off-by: Paul Poulain (cherry picked from commit 36d8e5df96d17df3d19a4693fff2ba52504fae51) Signed-off-by: Chris Nighswonger --- C4/SQLHelper.pm | 3 --- 1 file changed, 3 deletions(-) diff --git a/C4/SQLHelper.pm b/C4/SQLHelper.pm index 285f7d2b69..4c74df2599 100644 --- a/C4/SQLHelper.pm +++ b/C4/SQLHelper.pm @@ -43,9 +43,6 @@ BEGIN { ); } -my $tablename; -my $hash; - =head1 NAME C4::SQLHelper - Perl Module containing convenience functions for SQL Handling -- 2.20.1