From afb5166070dfcd87f5edfac26b1e6501407e4a2c Mon Sep 17 00:00:00 2001 From: Joe Atzberger Date: Thu, 30 Oct 2008 00:10:57 -0500 Subject: [PATCH] Squash warnings by checking if $type is defined before comparing it. Signed-off-by: Galen Charlton --- C4/Members.pm | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/C4/Members.pm b/C4/Members.pm index e756ffb7fb..7ee9eb3bbe 100644 --- a/C4/Members.pm +++ b/C4/Members.pm @@ -527,7 +527,7 @@ SELECT borrowers.*, categories.category_type, categories.description FROM borrowers LEFT JOIN categories on borrowers.categorycode=categories.categorycode "; - if ( defined $type && ( $type eq 'cardnumber' || $type eq 'firstname'|| $type eq 'userid'|| $type eq 'borrowernumber' ) ){ + if (defined($type) and ( $type eq 'cardnumber' || $type eq 'firstname'|| $type eq 'userid'|| $type eq 'borrowernumber' ) ){ $information = uc $information; $sth = $dbh->prepare("$select WHERE $type=?"); } else { @@ -535,14 +535,12 @@ LEFT JOIN categories on borrowers.categorycode=categories.categorycode } $sth->execute($information); my $data = $sth->fetchrow_hashref; - $sth->finish; ($data) and return ($data); - if ($type eq 'cardnumber' || $type eq 'firstname') { # otherwise, try with firstname + if (defined($type) and ($type eq 'cardnumber' || $type eq 'firstname')) { # otherwise, try with firstname $sth = $dbh->prepare("$select WHERE firstname like ?"); $sth->execute($information); $data = $sth->fetchrow_hashref; - $sth->finish; ($data) and return ($data); } return undef; -- 2.39.5