From b0b4973bdc622f3913bbde9f9acf57826e82c906 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Tue, 21 May 2019 13:19:17 +0000 Subject: [PATCH] Bug 22947: Markup error in OPAC preferences file This patch corrects a markup error in the OPAC .pref file which can cause display problems. The patch also corrects a validator warning by changing at to a . To reproduce the problem, go to Administration -> Global system preferences -> OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses two specific errors: - "Unclosed element code." - "The tt element is obsolete. Use CSS instead." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the display. Signed-off-by: Maryse Simard Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 87cbb27826a9d03a424e8c944293669157924a01) Signed-off-by: Fridolin Somers (cherry picked from commit 327977abd6fe95ff8ee8f743d690e3efc45501d5) Signed-off-by: Lucas Gass --- .../intranet-tmpl/prog/en/modules/admin/preferences/opac.pref | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref index 4d4d5b80c3..0d8f70aaa1 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref @@ -119,6 +119,8 @@ OPAC: yes: Include no: "Don't include" - "COinS / OpenURL / Z39.88 in OPAC search results.
Warning: Enabling this feature will slow OPAC search response times." + - "
If you want to display a link to an OpenURL resolver, look at the following system preferences:" + - "
OpenURLResolverURL, OPACShowOpenURL, OPACOpenURLItemTypes, OpenURLText, OpenURLImageLocation" - - pref: OPACShowUnusedAuthorities choices: @@ -593,7 +595,7 @@ OPAC: - Define custom rules to hide specific items from search and view on the OPAC. How to write these rules is documented on the Koha wiki. - - pref: OpacHiddenItemsExceptions - - List of borrower categories, separated by |, that can see items otherwise hidden by OpacHiddenItems + - List of borrower categories, separated by |, that can see items otherwise hidden by OpacHiddenItems - - pref: OpacAllowPublicListCreation default: 1 -- 2.39.2