From d4be7b10aca91a5af3e9614f465429c78a28fb13 Mon Sep 17 00:00:00 2001 From: Laura Escamilla Date: Mon, 28 Aug 2023 14:20:17 +0000 Subject: [PATCH] Bug 32048: Added clear cache routine to delete_holiday_range_repeatable When adding and deleting holidays, holidays might return unexpectedly. To test: 1 - Enter a holiday repeated yearly on a range from the 1st of the month to the 5th 2 - Delete it 3 - Add a new holiday from the 20th to the 25th 4 - When saved, the holiday from the 1st to the 5th is also added again. 5 - Apply patch and restart_all. 6 - Repeat steps 1-3. Notice that the holiday from the 1st to the 5th is no longer added and it has properly been cleared from the cache. 7 - Sign off! :D Signed-off-by: Salah Ghedda Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi --- C4/Calendar.pm | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/C4/Calendar.pm b/C4/Calendar.pm index 257119c8e3..6344bedd1e 100644 --- a/C4/Calendar.pm +++ b/C4/Calendar.pm @@ -603,6 +603,11 @@ sub delete_holiday_range_repeatable { my $dbh = C4::Context->dbh(); my $sth = $dbh->prepare("DELETE FROM repeatable_holidays WHERE (branchcode = ?) AND (day = ?) AND (month = ?)"); $sth->execute($self->{branchcode}, $options{day}, $options{month}); + + # changed the 'single_holidays' table, lets force/reset its cache + my $cache = Koha::Caches->get_instance(); + my $key = $self->{branchcode} . "_holidays"; + $cache->clear_from_cache($key); } =head2 delete_exception_holiday_range -- 2.20.1