From ee1cf549c5cb54767ece9e95fdf1c80d240ad9ea Mon Sep 17 00:00:00 2001 From: Aleisha Amohia Date: Tue, 18 Apr 2017 23:18:31 +0000 Subject: [PATCH] Bug 15815: Reword confirm message when removing patrons from card batch This patch rewords the confirm message when removing patrons from a card batch. From: "Are you sure you want to remove card number(s):1 from this batch?" To: "Are you sure you want to remove the selected patron(s) from this batch?" To test: 1) Go to Tools -> Patron Card Creator -> Manage batches 2) Edit a batch 3) Select one or more patrons and click 'Remove selected patrons' (not individual Delete buttons) 4) Confirm the message is worded better and easier to understand 5) Click OK and confirm the patrons are deleted as expected Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 4ac0aab9bb8418a355e1f692e6b505500c96e0dd) Signed-off-by: Katrin Fischer --- .../intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt index 9131ee4c05..d10d8d550a 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt @@ -18,18 +18,15 @@ }; function Remove() { items = new Array; - item_num = new Array; if(document.items.action.length > 0) { for (var i=0; i < document.items.action.length; i++) { if (document.items.action[i].checked) { items.push("label_id=" + document.items.action[i].value); - item_num.push(i+1); } } getstr = items.join("&"); - item_msg = item_num.join(", "); - var msg = _("Are you sure you want to remove card number(s): %s from this batch?").format(item_msg); + var msg = _("Are you sure you want to remove the selected patron(s) from this batch?"); } else if (document.items.action.checked) { alert(_("Deletion of patron from a batch with only one patron will delete the batch.") + "\n\n" + _("If this is what you want, select the 'Delete batch' option from the toolbar")); return; // no deletion for single item batch -- 2.39.5