From f231484ef33f2d478cc9683619db07fe8941a0b6 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Tue, 26 Sep 2023 14:42:08 +0000 Subject: [PATCH] Bug 34918: Fix hardcoded borrowernumber 42 Test plan: Run t/db_dependent/Koha/Item.t Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 3298b2798520b9e9d7d37848739dc0b24b5f2e0d) Signed-off-by: Fridolin Somers (cherry picked from commit 3dc01292aa869d1ad896e908bdd161fb19682b41) Signed-off-by: Jacob O'Mara --- t/db_dependent/Koha/Item.t | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/t/db_dependent/Koha/Item.t b/t/db_dependent/Koha/Item.t index c70b14d270..f4044e1b0c 100755 --- a/t/db_dependent/Koha/Item.t +++ b/t/db_dependent/Koha/Item.t @@ -346,7 +346,11 @@ subtest 'has_pending_hold() tests' => sub { my $item = $builder->build_sample_item({ itemlost => 0 }); my $itemnumber = $item->itemnumber; - $dbh->do("INSERT INTO tmp_holdsqueue (surname,borrowernumber,itemnumber) VALUES ('Clamp',42,$itemnumber)"); + my $patron = $builder->build_object( { class => 'Koha::Patrons' } ); + my $borrowernumber = $patron->id; + + $dbh->do( + "INSERT INTO tmp_holdsqueue (surname,borrowernumber,itemnumber) VALUES ('Clamp',$borrowernumber,$itemnumber)"); ok( $item->has_pending_hold, "Yes, we have a pending hold"); $dbh->do("DELETE FROM tmp_holdsqueue WHERE itemnumber=$itemnumber"); ok( !$item->has_pending_hold, "We don't have a pending hold if nothing in the tmp_holdsqueue"); -- 2.39.2