From f2eb9681457627e24ba44bcbb0aa64792a88cc4e Mon Sep 17 00:00:00 2001 From: Mason James Date: Tue, 25 Sep 2012 11:21:43 +1200 Subject: [PATCH] Bug 6679 - Fixing code so it passes basic Perl:::Critic tests opac/ilsdi.pl: Stricture disabled at line 217, column 17. See page 429 of PBP. (Severity: 5) Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Kyle M Hall Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Brendan A Gallagher --- opac/ilsdi.pl | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/opac/ilsdi.pl b/opac/ilsdi.pl index c53acc6bca..05e7c5cf90 100755 --- a/opac/ilsdi.pl +++ b/opac/ilsdi.pl @@ -17,15 +17,14 @@ # You should have received a copy of the GNU General Public License # along with Koha; if not, see . -use strict; -use warnings; - -use List::MoreUtils qw(any); +use Modern::Perl; use C4::ILSDI::Services; use C4::Auth; use C4::Output; use C4::Context; + +use List::MoreUtils qw(any); use XML::Simple; use CGI qw ( -utf8 ); @@ -217,7 +216,7 @@ if ( $service and any { $service eq $_ } @services ) { # Variable functions my $sub = do { - no strict 'refs'; +# no strict 'refs'; my $symbol = 'C4::ILSDI::Services::' . $service; \&{"$symbol"}; }; -- 2.39.5