From ffae11293afb3f80e434e7c84b75e240f7512350 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Wed, 4 Jul 2018 16:49:38 +0200 Subject: [PATCH] Bug 21036: Fix uninitialized value within @itemnumber in string ne Line from 16.11 log: Use of uninitialized value within @itemnumber in string ne at /usr/share/koha/prodclone/reserve/modrequest.pl line 70. Test plan: Read the change. Not 100% identical (numeric zero) but should be enough. This line is probably not needed at all. Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens (cherry picked from commit 4560d9623663e9fd0b60f9a39ec53082cdd90f24) Signed-off-by: Martin Renvoize --- reserve/modrequest.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reserve/modrequest.pl b/reserve/modrequest.pl index 6b4061c724..0d1b2d0262 100755 --- a/reserve/modrequest.pl +++ b/reserve/modrequest.pl @@ -66,7 +66,7 @@ if ($CancelBorrowerNumber) { # 2) Cancel or modify the queue list of reserves (without item linked) else { for (my $i=0;$i<$count;$i++){ - undef $itemnumber[$i] unless $itemnumber[$i] ne ''; + undef $itemnumber[$i] if !$itemnumber[$i]; ModReserve({ rank => $rank[$i], reserve_id => $reserve_id[$i], -- 2.39.5