From 55312cd9f8789d03acb9251d342afd5ac76e842c Mon Sep 17 00:00:00 2001
From: Slava Shishkin <slavashishkin@gmail.com>
Date: Sun, 10 May 2020 18:15:09 +0300
Subject: [PATCH] Bug 25409: Add missing "Required" text and "required" classes
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

Highlight text with red by adding “required” class to the label and added red
“Required” text next to select field in "onboardingstep5.tt" template.

To test:
    1) Start new installation. During onboarding tool phase you will be
       requested to create a new circulation rule.
    2) Observe that "Units" label has no "required" class and that
       there’s no “Required” text next to a select field.
    3) Apply patch.
    4) Repeat step 2 (you can reload circulation rule creation page).
    5) Observe the error is gone.

Mentored-by: Peter Vashchuk <stalkernoid@gmail.com>
Mentored-by: Andrew Nugged <nugged@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
(cherry picked from commit e21179fd9bad471c931ce0e89cd8f4df145af8f1)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
---
 .../prog/en/modules/onboarding/onboardingstep5.tt              | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt
index e84125a77a..01ba75b4f8 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt
@@ -79,7 +79,7 @@
                                     <span class="required">Required</span>
                                 </li>
                                 <li>
-                                    <label for="lengthunit">Units: </label>
+                                    <label for="lengthunit" class="required">Units: </label>
                                     <select name="lengthunit" id="lengthunit" required="required">
                                         <option value=""> Choose </option>
                                         [% SET units = 'days' %]
@@ -96,6 +96,7 @@
                                             <option value="hours" selected="selected">Hours</option>
                                         [% END %]
                                     </select>
+                                    <span class="required">Required</span>
                                 </li>
                                 <li>
                                     <label for="renewalsallowed" class="required">Renewals allowed: </label>
-- 
2.39.5