From 780bc5ecd9be9b645b7fdccc2bcc331dd7df2081 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Tue, 15 Sep 2015 08:24:07 +0100
Subject: [PATCH] Bug 14821: Do not list not returned items
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

On the checkin page, the table is always filled with info of the scanned
barcode, even if the checkin has failed.
When the checkin fails, there is already an error displayed, so there is
no need to keep a row for fails.

Test plan:
Confirm that the failed checkins don't appear anymore in the checkin
table.
- checkin an item which is not issued;
- BlockReturnOfWithdrawnItems is set and item is withdrawn;
- Not returned at the right place;
- privacy=2 and AnonymousPatron not correctly set;

Before this patch this behavior existed only for bad barcode.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
  I confirm that the checkin table hasn't to be populated with info on items
  which haven't been checked in.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 8122df1f8788cbd695e06aa4c1acfa345da8cadc)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
---
 circ/returns.pl | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/circ/returns.pl b/circ/returns.pl
index f6f6e00d64..3bbdee09ad 100755
--- a/circ/returns.pl
+++ b/circ/returns.pl
@@ -331,12 +331,6 @@ if ($barcode) {
             }
         }
     }
-    elsif ( !$messages->{'BadBarcode'} ) {
-        $input{duedate}   = 0;
-        $returneditems{0} = $barcode;
-        $riduedate{0}     = 0;
-        push( @inputloop, \%input );
-    }
     $template->param( privacy => $borrower->{privacy} );
 }
 $template->param( inputloop => \@inputloop );
-- 
2.39.5