From 444e4b1f89e3b7fd9e25688a718d3f2cc9ed3100 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 19 Jun 2019 14:49:15 -0500 Subject: [PATCH] Bug 23150: Do not consider gdpr_proc_consent a mandatory field It introduced a regression in the patron's self modification feature. Patron's details are no longer modificable, the screen displays "You have not filled out all required fields. Please fill in all missing fields and resubmit." Test plan: - Set GDPR_Policy to either Enforced or Permissive - Set PatronSelfRegistrationBorrowerMandatoryField to empty - Set OPACPatronDetails to Allow - Log into the OPAC - Accept the GDPR screen - Go to opac-memberentry.pl, change something, submit modification request Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize (cherry picked from commit 3b14f7d636fea4425b2f6eab922be9aa2a9eed1d) Signed-off-by: Fridolin Somers (cherry picked from commit 502565a21cc71d13711d0194f809ac6062c9009b) Signed-off-by: Lucas Gass --- opac/opac-memberentry.pl | 1 - 1 file changed, 1 deletion(-) diff --git a/opac/opac-memberentry.pl b/opac/opac-memberentry.pl index dbb6d99e5c..e84c11b0e6 100755 --- a/opac/opac-memberentry.pl +++ b/opac/opac-memberentry.pl @@ -369,7 +369,6 @@ sub GetMandatoryFields { C4::Context->preference("PatronSelfRegistrationBorrowerMandatoryField"); my @fields = split( /\|/, $BorrowerMandatoryField ); - push @fields, 'gdpr_proc_consent' if C4::Context->preference('GDPR_Policy'); foreach (@fields) { $mandatory_fields{$_} = 1; -- 2.39.5