From a641e8867ee2a31a7da0ec18fcdcb3422fcaad89 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 22 Nov 2021 14:24:40 +0100 Subject: [PATCH] Bug 29524: (bug 28935 follow-up) Restore modification of some patron's attributes On commit 5f37d8d2f496ce3c9fd6dfd5a2efa7a9fe435af3 Bug 28935: No filtering on patron's data on member entry pages we restricted the list of the columns from the borrowers table that can be modified from the patron edit view. We were too restrictive, the following 3 attributes can be edited from this form: privacy_guarantor_fines, privacy_guarantor_checkouts, checkprevcheckout and lang Test plan: Turn on the following prefs: - AllowStaffToSetFinesVisibilityForGuarantor - AllowStaffToSetCheckoutsVisibilityForGuarantor - CheckPrevCheckout (set to 'unless overridden *') - TranslateNotices Edit a patron and see the 4 different options are now displayed. Change their value, save, edit again Confirm that the values have been saved Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 0ca1419b26be84f7670f60446e621cfd878f6580) Signed-off-by: Victor Grousset/tuxayo (cherry picked from commit 04df6726ab9b9a14d7d0f2353c3b8cdc1d28b63e) Signed-off-by: Wainui Witika-Park (cherry picked from commit 04df6726ab9b9a14d7d0f2353c3b8cdc1d28b63e) --- members/memberentry.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/members/memberentry.pl b/members/memberentry.pl index 9df6dbc4c2..2d0fc09cfc 100755 --- a/members/memberentry.pl +++ b/members/memberentry.pl @@ -222,7 +222,7 @@ if ( $op eq 'insert' || $op eq 'modify' || $op eq 'save' || $op eq 'duplicate' ) # remove keys from %newdata that is not part of patron's attributes { my @keys_to_delete = ( - qr/^(borrowernumber|date_renewed|debarred|debarredcomment|flags|privacy|privacy_guarantor_fines|privacy_guarantor_checkouts|checkprevcheckout|updated_on|lastseen|lang|login_attempts|overdrive_auth_token|anonymized)$/, # Bug 28935 + qr/^(borrowernumber|date_renewed|debarred|debarredcomment|flags|privacy|updated_on|lastseen|login_attempts|overdrive_auth_token|anonymized)$/, # Bug 28935 qr/^BorrowerMandatoryField$/, qr/^category_type$/, qr/^check_member$/, -- 2.39.5