Beginning some design changes to the OPAC: put login info at the top, move cart and list buttons alongside main search form. Putting alternate search methods below the search form. These changes will eliminate the left-hand column from most OPAC screens.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Partial fix for Bug 1578: detect material type and don't load COinS unless the material type is known.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

retab, 4 chars, spaces

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

cleanup of opac-search.pl, synch with search.pl, etc.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

mapping recordIdentifier to Koha internal ID

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Backend for "Session" Shelves in toolbar. Affects Auth and Context, so please test.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Auth.pm - Clarify logout conditionals, debug messages. Die on failure of get_session("").

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

holidays.tmpl - format cleanup, CSS-ification, English corrections

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Auth.pm - _session_log calls moved before undef of vars logged, LibraryName double => removed

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Removing replace statement as per bug 1546

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Tidying up formatting

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1790 Thanks to Chris Nighswonger

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1791

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Bug Fixing : Encoding in Z3950 searches

encoding is now defaulted to MARC8
encoding is now supported for USMARC and UNIMARC flavours.
Adding Encoding field to updatedatabase.pl

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1772, thanks for the bug report Arona

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

basket.pl - bugfix 1714, GST pre-inclusion checked. FIXME's added.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Help for tools-home.pl added by Brooke

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1560

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix bug #1789 part 1

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Correcting path to linked css and js

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

One more search button correction

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Tweaking display of search button in resident search form to address an issue described in Bug 1780.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding noItemTypeImages syspref to Auth.pm; Beginning the process of adding support for noItemTypeImages preference to intranet templtes.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Bug, using branchcode instead of branch

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1784,

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

C4::Debug - Centralized debug switches module, test and proof conversion (in Dates.pm)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Displaying mobile or phonepro if no phone number.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding back the HomeorHoldingBranch syspref ... Dont Delete this is used by

Circulation

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Shifting HomeOrHoldingBranch to the circulation tab

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixed permissions for updateitem

Per new bug 1783, it would be nice if editcatalogue would
work as well, but a change to the public API of C4::Auth
is needed for that to work.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

more items work; handle unlinked subfields (DB rev => 048)

As a consequence, the items table now remains authoritative
for all item information: any subfields not explicitly mapped
in the framework are still stored.

In addition, the additional unlinked subfields are now retained
during a call to ModItem.

Two additional points of note:

* an upgrade script from 2.2 and earlier 3.0 instllations is needed
  to populate items.marc_subfields_xml; I am working on this.
* A behavour of bulkmarcimport.pl has now changed; any item subfields
  not explicitly mapped to a Koha items field were dropped; they are
  now retained and are stored in items.more_subfields_xml.  This can
  affect data migrations.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

added caching of results of GetMarcStructure

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

C4::Items -- removed two warns

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

editorial changes to C4/Items.pm

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

prevent AddItem death if no marcrecord is given.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Important Commit For UNIMARC Items.

Nonetheless, you are right to consider items table as the reference.
We need one, and we agree on this principle.

What is done with this commit is :
- adding support for marc subfields not linked to items table.

+ removing some $dbh parameters in some function signature.
I think this is rel2_2 style programming and may be avoided using C4::Context->dbh.
Or there is a reason using dbh parameter that you know and not me.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bulkauthimport fix

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

correctly caluclate default template path for OPAC

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding dateexpiry to borrowers search result list

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1773, reading record not showing properly in the OPAC

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding a few credits for translation team

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding changelanguage feature to OPAC

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

moving a misplaced * to fix a bug in issuingrules

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Delete labels/label-select-pdf.pl - Cannot see where this was/is being used.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixing a bug that meant you had to have totals defined for

branch/itemtype/category in issuingrules, or TooMany would always fail

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1766 typo in sys pref explanation for dontmerge

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

BugFixing : default language was always en. Not a problem for dev purpose but would be on installation

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Shelves wrap up - bugfix 1405, opac checkbox js fixed

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

BugFixing : 1299 /displaying lists for document types and borrower categories

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

sco.js - trivial javascript cleanup, comment

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Shelves - bugfix 1403 amongst others

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Displaying AuthorisedValues for items linked with authorised_value lists.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

displaying button Renew All only if syspref OpacRenewalAllowed is set.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding utf8 encoding for RSS.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Avoid double renew button when subscription is over

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding syspref PatronsPerPage

PatronsPerPage stores the number of patrons to display per page.
Default is 20

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1541, Show area name rather than number

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixing a broken redirect in the reports dictionary

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixing a bug where a cgi object wasnt being passed, in the reports dictionary

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Finishing off bug 1427, if the person has ReturnBeforeExpiry set they are

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Small change to fix alignment of login menu

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Overhaul to Koha's js-menu systems. New language-picker in the footer required more flexibility than jquery's clickmenu plugin offered, so both the language picker and the main navigation menu now use YUI's menu plugin. The necessary dependencies have been added, and ClickMenu-related files removed.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Patch

See attached file. Thanks.

>From b0d40589f4fa0921ee05073b14903ed79b90c474 Mon Sep 17 00:00:00 2001
From: Frederic DEMIANS <f.demians@tamil.fr>
Date: Mon, 14 Jan 2008 14:20:35 +0100
Subject: [PATCH] Sample News in French

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Changing Libraryname heading style so it displays

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1539

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for if a supplier is added without a name

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1428

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1762, links on bookcount.pl dont work

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Going to next line for each search line in searchbox

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding OpacRenewalAllowed systempref (bump to 047)

to let the library decide wheter their patrons can or can't renew checked-out items directly from their account.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

A book can be renewed if renewalsallowed > to renewals done, not >=

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

display notforloanvalue correctly

Not displaying Available if itemnotforloan is set (& item is not for loan)
The description of the status is enough (being repaired, excluded from loan, ...)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

some reindenting

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

itemtypes.pl - partial revisions, incl. replacement of invalid META Refresh calls

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Dates - remove extra newlines from carps, add partial "00" date tests to Dates.t

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Output.pm - silence unconditional warn.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Shelves consolidation to C4::VirtualShelves::Page. I can tell the consolidation

worked b/c the pages still display their previous behavior, including unfixed bugs.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

add three missing packages to Debian list

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding a few _() for translator

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

hdl has added a Text::Iconv dependancy yesterday, checking it in installer

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

translation for subtag_registry

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

category entry javascript fix

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Revert "adding TRUNCATES before INSERTS"

This reverts commit 732c11be895b3b2c79942c1071d11f497d87f1dc.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for 1599 getting expiry date prepopulating on member entry

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Labels.pm - BEGIN block VERSION and vars related to export.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

catalogue - exit after redirect in detail.pl and updateitem.pl

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix record->field call on autobarcode

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Populate serialitems table, bugfix

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

nomenclature changes and hide advanced numbering by default

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Escaping the $title in the regexes with \Q and \E to handle nested quantifiers, cheers chris :)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Shelves reworking - fix handling of itemtype images, symlink to opac icons.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding TRUNCATES before INSERTS

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Shelves - bugfix, toggle "Holds" link, add "Author" column to intranet

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix for 1754; fixing I18N BiDi, improvements to handling of language

TODO: clean up the OPAC similarly

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fixing unclosed TMPL_UNLESS, reported in Bug 1757.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding yuipath variable to help.pl, and doing some cleanup of help templates (standardizing structure, mostly, and correcting some nomenclature).

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1686

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Calendar (js) tweaks: histsearch fixed, viewlog template updated

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Removing unused include

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Cleanup for member entry: XHTML-compliance (close inputs, ids must match labels) and translator-friendliness (can't embed TMPL_IF inside tags); Cleanup of circ and members menus; Menu context flag for readingrec.pl; Correction to Auth.pm (updatecharge -> updatecharges)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>