From e28854ed82ac80045d3cc604c4902d15ae8e1d73 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Thu, 29 Dec 2011 11:47:44 -0500 Subject: [PATCH] Bug 3651 Follow-up, Require patron login to send shelves and baskets The fix for Bug 4289, "Add a syspref 'OpacPublic', to hide OPAC search-bar and force authentication on all OPAC pages" incorrectly made some page permissions dependent on the value of the OpacPublic setting. Some pages should require authentication no matter what. This patch returns opac-sendbasket.pl to the state it was in before Bug 4289, Bug 4274 notwithstanding. I have added the authentication requirement to opac-sendshelf.pl to match. Signed-off-by: Katrin Fischer 1) sending cart requires login 2) sending shelf requires login 3) updating personal details requires login Signed-off-by: Paul Poulain (cherry picked from commit 9e70695907d97953e097087425ccaaefd3809897) Signed-off-by: Chris Nighswonger (cherry picked from commit 54ed58310d806a84f82406abc00f46834bfe3c6e) Signed-off-by: Chris Nighswonger --- opac/opac-sendbasket.pl | 2 +- opac/opac-sendshelf.pl | 4 ++-- opac/opac-userupdate.pl | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/opac/opac-sendbasket.pl b/opac/opac-sendbasket.pl index df1b4c5114..6a6e8253ba 100755 --- a/opac/opac-sendbasket.pl +++ b/opac/opac-sendbasket.pl @@ -39,7 +39,7 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user ( template_name => "opac-sendbasketform.tmpl", query => $query, type => "opac", - authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 ), + authnotrequired => 0, flagsrequired => { borrow => 1 }, } ); diff --git a/opac/opac-sendshelf.pl b/opac/opac-sendshelf.pl index b571e07185..6de546b911 100755 --- a/opac/opac-sendshelf.pl +++ b/opac/opac-sendshelf.pl @@ -41,7 +41,7 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user ( template_name => "opac-sendshelfform.tmpl", query => $query, type => "opac", - authnotrequired => 1, + authnotrequired => 0, flagsrequired => { borrow => 1 }, } ); @@ -185,4 +185,4 @@ END_OF_BODY url => "/cgi-bin/koha/opac-sendshelf.pl", ); output_html_with_http_headers $query, $cookie, $template->output; -} \ No newline at end of file +} diff --git a/opac/opac-userupdate.pl b/opac/opac-userupdate.pl index aa5858a9f7..370a6c6fef 100755 --- a/opac/opac-userupdate.pl +++ b/opac/opac-userupdate.pl @@ -40,7 +40,7 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user( template_name => "opac-userupdate.tmpl", query => $query, type => "opac", - authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 ), + authnotrequired => 0, flagsrequired => { borrow => 1 }, debug => 1, } -- 2.39.5