]> git.koha-community.org Git - koha.git/commit
Bug 7047: Storing subscription renewal note in suggestion to be displayed on the...
authorAlex Buckley <alexbuckley@catalyst.net.nz>
Mon, 4 Dec 2017 00:35:01 +0000 (13:35 +1300)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Mon, 23 Dec 2019 12:06:28 +0000 (12:06 +0000)
commit5c5f8ecfed387cef647dcc9d37b8bca1eac7480c
tree423ccd43bde668bd989afba395acc6338d9283f9
parent58a36dd18612b0d6c1734992937f8e9fd40f510f
Bug 7047: Storing subscription renewal note in suggestion to be displayed on the suggestion page.

Additionally I have added a library input field in case the librarian wants to set a library branch whilst renewing a subscription. With the use case being they may have ommitted to set the branchcode whilst creating the subscription.

Test plan:
1. Create a subscription (if one does not already exist)

2. Set the RenewSerialAddsSuggestion syspref to 'Add'

3. Renew the item making sure to write in a value into the note field

3. Visit the suggestions page and notice that the note is not displayed
for the newly created suggestion

4. Apply patch

5. Repeat step 3. Notice that there is now a new branchcode dropdown
box. Select one of your libraries and write in the value into the note
field

6. Visit suggestions and notice there is now a 'Suggestion note' column
in the table containing the note.

Also note that the suggestion has the correct branchcode associated with
it

Sponsored-By: Catalyst IT
Signed-off-by: Maksim Sen <maksim@inlibro.com>
Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
C4/Serials.pm
koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-renew.tt
koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
serials/subscription-renew.pl
suggestion/suggestion.pl