From 8c45ed8601ce8ebe6c4b2c6ccc452865921a7ae9 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 19 Oct 2018 10:15:56 +0200 Subject: [PATCH] Bug 21613: (QA follow-up) Resolve warning on $ENV{_} Some shells may not pass the program name in underscore, and cron also does not like it here: Use of uninitialized value $ENV{"_"} in pattern match (m//) at Koha/Database.pm line 79. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens --- Koha/Database.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Koha/Database.pm b/Koha/Database.pm index 1da498fee4..2d6110adde 100644 --- a/Koha/Database.pm +++ b/Koha/Database.pm @@ -76,7 +76,7 @@ sub _new_schema { %encoding_attr = ( mysql_enable_utf8 => 1 ); $encoding_query = "set NAMES 'utf8mb4'"; $tz_query = qq(SET time_zone = "$tz") if $tz; - if ( $ENV{_} =~ m|prove| or C4::Context->config('strict_sql_modes') ) { + if ( ( $ENV{_} && $ENV{_} =~ m|prove| ) or C4::Context->config('strict_sql_modes') ) { $sql_mode_query = q{SET sql_mode = 'ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION'}; } else { $sql_mode_query = q{SET sql_mode = 'IGNORE_SPACE,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION'}; -- 2.39.5