From 878c25efb5d0067a0b398eeee84fa8539a5f4c0d Mon Sep 17 00:00:00 2001 From: Mark Tompsett Date: Sat, 18 Feb 2017 19:21:59 -0500 Subject: [PATCH] Bug 18143: Silence XML MARC Framework export flood TEST PLAN --------- 1) Log in to staff client 2) Click Koha administration 3) Click MARC bibliographic framework 4) export default as xml 5) Read the error log -- it's floody and export is default framework 6) export another framework as xml 7) Read the error log -- it's floody and export is the correct framework 8) apply the patch 9) repeat steps 4-7 -- expected frameworks exported, and no flooding. 10) run koha qa test tools Signed-off-by: Pierre-Marc Thibault Signed-off-by: Kyle M Hall Signed-off-by: Nick Clemens (cherry picked from commit 719153455c8c58fb8b1a8e9123acef5052dbd462) Signed-off-by: Martin Renvoize (cherry picked from commit 65a6cd355ef227ab4e11b620f485f010b611e115) Signed-off-by: Lucas Gass (cherry picked from commit e6bfbc6832fb5a4b87f7e12f6e45e6d814f5b311) Signed-off-by: Fridolin Somers --- C4/ImportExportFramework.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/C4/ImportExportFramework.pm b/C4/ImportExportFramework.pm index bc02cca203..f89c76878e 100644 --- a/C4/ImportExportFramework.pm +++ b/C4/ImportExportFramework.pm @@ -415,6 +415,8 @@ sub _export_table_excel $data = $hashRef->{$_->{name}}; if ($_->{type} eq 'Number' && !defined($data)) { $data = '0'; + } elsif ($_->{type} eq 'String' && !defined($data)) { + $data = q{}; } elsif ($_->{type} eq 'String' && (!$data && $data ne '0')) { $data = '#'; } -- 2.39.5