From bedf692a3c348612f7e97dd2d0e428cab257185d Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Fri, 24 Apr 2020 14:24:07 +0000
Subject: [PATCH] Bug 25276: Correct hover style of list share button in the
 OPAC

This patch adds missing "btn" classes to the OPAC share button so that
its style is consistent with similar controls.

The patch also makes some general changes to the OPAC CSS to make sure
link color and hover color are applied with enough specificity. This
corrects the hover color of the share button but should not change any
other existing style.

To test you should have the OpacAllowSharingPrivateLists preference
enabled.
 - Rebuild the OPAC CSS
   (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
 - Log in to the OPAC as a user with one or more private lists.
 - Go to Lists -> Your lists.
 - In the list of lists there should be a "Share" link for each list.
   Hovering your mouse pointer over the link should change the style in
   the same way the "Edit" link does.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
---
 .../opac-tmpl/bootstrap/css/src/_mixins.scss  |  1 +
 .../opac-tmpl/bootstrap/css/src/opac.scss     | 26 ++++++++++++-------
 .../bootstrap/en/modules/opac-shelves.tt      |  2 +-
 3 files changed, 18 insertions(+), 11 deletions(-)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/_mixins.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/_mixins.scss
index 3b529af87d..92ae489c92 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/css/src/_mixins.scss
+++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/_mixins.scss
@@ -1,5 +1,6 @@
 $color: #999999;
 $links: #0076B2;
+$links-hover: #005580;
 $footer-height: 45px;
 
 $sci-link-color: #0076B6;
diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
index bc88f42d10..f519d49dd8 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
+++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
@@ -60,14 +60,18 @@ $footer-height: 45px;
 }
 
 a {
-    color: $links;
+    &:link,
+    &:visited {
+        color: $links;
+    }
 
-    &.cancel {
-        padding-left: 1em;
+    &:hover,
+    &:active {
+        color: $links-hover;
     }
 
-    &:visited {
-        color: $links;
+    &.cancel {
+        padding-left: 1em;
     }
 
     &.title {
@@ -813,8 +817,6 @@ ul {
 
     .ui-state-default {
         a {
-            color: #006699;
-
             &:link {
                 color: #006699;
             }
@@ -826,8 +828,6 @@ ul {
     }
 
     .ui-state-hover a {
-        color: #990033;
-
         &:link {
             color: #990033;
         }
@@ -976,10 +976,14 @@ ul {
     border: 1px solid #AAA;
     color: #222222;
 
-    a,
+    a:link,
     a:visited {
         color: $links;
     }
+    a:hover,
+    a:active {
+        color: $links-hover;
+    }
 }
 
 .ui-widget-header {
@@ -2294,8 +2298,10 @@ input {
 
 button {
     &.btn-link {
+        color: $links;
         &:focus,
         &:hover {
+            color: $links-hover;
             text-decoration: none;
         }
     }
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
index a41278acea..d7262d1508 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
@@ -717,7 +717,7 @@
                                                         </form>
                                                     [% END %]
                                                     [% IF s.is_private AND s.can_be_managed( loggedinusernumber ) AND Koha.Preference('OpacAllowSharingPrivateLists') %]
-                                                        <a href="/cgi-bin/koha/opac-shareshelf.pl?op=invite&shelfnumber=[% s.shelfnumber | uri %]" class="sharelist"><i class="fa fa-share"></i> Share</a>
+                                                        <a href="/cgi-bin/koha/opac-shareshelf.pl?op=invite&shelfnumber=[% s.shelfnumber | uri %]" class="sharelist btn btn-link"><i class="fa fa-share"></i> Share</a>
                                                     [% END %]
                                                     [% IF s.is_shared_with( loggedinusernumber ) %]
                                                         <form action="opac-shelves.pl" method="post" class="form-inline">
-- 
2.39.5