From ee2d5ae04dc4c5fed9f09c9067c3de0037cdba8e Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 7 Sep 2018 09:50:40 +0200 Subject: [PATCH] Bug 13779: (QA follow-up) Correct checkauth call in offline_circ/download.pl Script offline_circ/download.pl does not use the return values of checkauth. So should not assign them to bad chosen variables that do not correspond with checkauth but with get_template_and_user. Test plan: Look for $template, $loggedinuser, $cookie, $flags in the code. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens (cherry picked from commit bf7082f854a1db9eb5b7eb77e5f450d018d8e07b) Signed-off-by: Martin Renvoize --- offline_circ/download.pl | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/offline_circ/download.pl b/offline_circ/download.pl index 713057c805..2b6c67e113 100755 --- a/offline_circ/download.pl +++ b/offline_circ/download.pl @@ -27,8 +27,7 @@ use C4::Context; use C4::Koha; my $query = new CGI; -my ( $template, $loggedinuser, $cookie, $flags ) = - checkauth( $query, undef, { circulate => "circulate_remaining_permissions" }, +checkauth( $query, undef, { circulate => "circulate_remaining_permissions" }, "intranet" ); my $page = $query->param('page') || 0; -- 2.39.5