From 04126b54eb1dc99a9f514d4f6c28783fc56a0083 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 3 May 2024 09:07:17 +0000 Subject: [PATCH] Bug 34972: (QA follow-up) Remove second transfer from Circulation.t Removing the manual transfer and rightaway doing the Reserve transfer. One test description was misleading too. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer (cherry picked from commit 7f22156b8fea3766f893d28fc17ebe8561d5e7cc) Signed-off-by: Fridolin Somers (cherry picked from commit dce78a0ecd7530fd5f372c3b5d8e92998a983529) Signed-off-by: Lucas Gass --- t/db_dependent/Circulation.t | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t index 7f082119df..a243318f39 100755 --- a/t/db_dependent/Circulation.t +++ b/t/db_dependent/Circulation.t @@ -5498,12 +5498,8 @@ subtest 'Checkout should correctly terminate a transfer' => sub { my $do_transfer = 1; ModItemTransfer( $item->itemnumber, $library_1->branchcode, - $library_2->branchcode, 'Manual' ); + $library_2->branchcode, 'Reserve' ); ModReserveAffect( $item->itemnumber, undef, $do_transfer, $reserve_id ); - ModItemTransfer( - $item->itemnumber, $library_1->branchcode, - $library_2->branchcode, 'Reserve' - ); # To put the Reason, it's what does returns.pl... my $hold = Koha::Holds->find($reserve_id); is( $hold->found, 'T', 'Hold is in transit' ); my $transfer = $item->get_transfer; @@ -5516,7 +5512,7 @@ subtest 'Checkout should correctly terminate a transfer' => sub { $transfer = $transfer->get_from_storage; isnt( $transfer->datearrived, undef ); $hold = $hold->get_from_storage; - is( $hold->found, undef, 'Hold is waiting' ); + is( $hold->found, undef, 'Hold is not waiting or transit' ); is( $hold->priority, 1, ); }; -- 2.39.5