]> git.koha-community.org Git - koha.git/commit
Bug 20218: Fix matching of uri in tracklinks
authorNick Clemens <nick@bywatersolutions.com>
Fri, 16 Feb 2018 12:31:39 +0000 (12:31 +0000)
committerNick Clemens <nick@bywatersolutions.com>
Fri, 23 Mar 2018 10:30:01 +0000 (10:30 +0000)
commit306b461a6a8e57814367de524dfa3bd22c2f3eca
tree6363179fe3000bcead3ff37c23ad2b0342d26d10
parentd088816f8a833358557454e84bdbf04a0b7f3232
Bug 20218: Fix matching of uri in tracklinks

The current code matches using a regex, this breaks when the url
contains special characters. We swtich it to equality check

To test:
1 - Enable TrackClicks (either track or anonymous)
2 - Find the URL of a biblio in the OPAC
3 - Paste this into the 856$u of another record
    (or use any url containing a '?' or other characters)
4 - View the record in the opac
5 - Click the URL
6 - 404 Error!
7 - Apply patch
8 - Try again
9 - Success!

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
opac/tracklinks.pl