Colin Campbell [Thu, 24 Jun 2010 14:57:21 +0000 (15:57 +0100)]
Bug 4905 Runtime errors in about.pl
Calls to VERSION were generating errors when called on a string.
Use a bit of sleight of hand to avoid this
Added a couple of tests on Installer/PerlModules
Module needs better coverage testing (esp on newer perls)
Sorted to list of modules to make koha_perl_deps.pl more
human-friendly
Galen Charlton [Mon, 22 Feb 2010 02:49:09 +0000 (21:49 -0500)]
bug 4224: explicitly mark hold requests as being handled by item in transit
This patch defines a new values of reserves.found, 'T', to indicate that
an item has been allocated to fill a hold request and is currently
in transit from one branch to another. This explicit value is meant
to filter out hold requests from processing by holds queue batch
job.
Owen Leonard [Wed, 19 May 2010 15:47:37 +0000 (11:47 -0400)]
Fix for Bug 4532, Use include file for bibliodefaultview logic
Note that this new include builds only the first half of the
anchor tag (<a>). Because title and subtitle are output differently
on some pages, rendering of the second half of the tag is left
to individual pages.
Includes fixes for staff client templates.
Change to basket.pl fixes a bug wherein the OPAC's bibliodefaultview
preference was being checked instead of the staff client's.
Owen Leonard [Fri, 28 May 2010 18:50:30 +0000 (14:50 -0400)]
Partial fix for Bug 4423, Staff Client XSLT is just a copy of the OPAC one
This patch improves the template logic specifying a layout
based on whether the display is XSLT or normal, and whether
Amazon Content is on or off. Previously XSLT view did not
display Amazon covers when enabled.
Owen Leonard [Thu, 10 Jun 2010 17:09:14 +0000 (13:09 -0400)]
Fix for Bug 4884, opac-showmarc.pl can't find compact.xsl
This patch implements Fridolyn SOMERS' suggested change
to the .xsl file path but copies compact.xsl from the
intranet template dir and points to that instead.
Owen Leonard [Thu, 10 Jun 2010 18:14:26 +0000 (14:14 -0400)]
Fix for Bug 4869 - Non-staff patrons logging into the OPAC don't have option to place holds from Public Lists
The template was originally designed so that form controls were
hidden from users who didn't have permission to modify a particular
shelf because the form controls were only used for deleting from
lists. Now that users can place holds and add tags via the check-
boxes, the controls must be available to all users.
This was owed to the Item modification construction and the change in GetBranchesLoop behaviour which selects the user branch by default.
Adding a void branch selected
Changing default value to ""
Nicole Engard [Mon, 21 Jun 2010 14:32:21 +0000 (10:32 -0400)]
bug 4900: add in missing value for usedaysmode pref
The usedaysmode preference was missing the option to
calculate due date by finding the next open date on the
calendar instead of ignoring all days the library is
closed.
Galen Charlton [Sat, 19 Jun 2010 19:56:07 +0000 (15:56 -0400)]
fixes to xt/sysprefs.t test case
* use root of source tree as base directory
* ignore case when comparing system preference codes;
at present this is also case-insenstive in the database
* added German sysprefs file
* corrected paths to Russian and Ukrainian system preference files
Galen Charlton [Sat, 19 Jun 2010 19:51:25 +0000 (15:51 -0400)]
fixed permissions for item batch deletion and modification for French
Solves bug where granular permissions for batch deletion and modification
would not work correction for a fresh installation using the French
translation.
Galen Charlton [Sat, 19 Jun 2010 19:48:28 +0000 (15:48 -0400)]
fixed problems in xt/permissions.t test case
* now looks for permissions SQL files in the current
source tree, not in intranetdir; tests in xt/ and
t/ are meant to be run without requiring a full Koha
installation
* added path to German
* fixed paths to permissions SQL for Russian and Ukrainian
* handles case where SQL script contains more than just
inserts into to permissions
Galen Charlton [Sat, 19 Jun 2010 11:53:59 +0000 (07:53 -0400)]
bug 4896: granular permissions now always on (DB rev 138)
Per the following koha-devel thread, the use of
staff user subpermissions, AKA granular permissions, is
now the default behavior in Koha. This patch removes
the GranularPermissions system preference.
Liz Rea [Wed, 9 Jun 2010 18:27:35 +0000 (13:27 -0500)]
Changing <p> to <span> per gmcharlt's suggestion re: Adding <p class="noholdstext"> tag around the "No Holds Allowed" text to allow for jquery selection/replacement of the text.
The plugin was returning a 25 characters length leader rather than 24
characters. So leader was recreated automatically, removing user update,
before writing biblio record.
Andrew Elwell [Sat, 5 Jun 2010 11:16:51 +0000 (13:16 +0200)]
The start of some POD cleanups in C4/*.pm
If these are acceptable I'll continue - target is to get rid of all warnings
and errors with podcheck and make sure that any man and html formatted pod
docs look 'OK'
Lars Wirzenius [Fri, 4 Jun 2010 02:52:44 +0000 (14:52 +1200)]
Remove dependencies on perl-base.
perl-base is a required package, so it is always installed on a Debian
system, and Debian packages should not depend on it, unless they need
it a specific version, and I don't think we do.
Owen Leonard [Fri, 28 May 2010 14:49:46 +0000 (10:49 -0400)]
Fix for Bug 3081, Url's contain spaces
My investigation finds that the problem in Internet
Explorer was not with the spaces in the URL but
with the spaces in the "name" attribute of the pop-up
window. Converting spaces to underscores allows
the plugin links to work correctly.
Owen Leonard [Thu, 3 Jun 2010 17:37:33 +0000 (13:37 -0400)]
Fix for Bug 3722 - Branch deletion results in incorrect message
A fix was submitted by Nahuel on 23 Nov 2009 and pushed, but
it combined messages for existing patrons and existing items.
This patch defines separate messages for the various cases and
corrects a typo in the original fix which left existing patrons
unreported.
Nicole Engard [Thu, 27 May 2010 03:55:52 +0000 (23:55 -0400)]
bug 4834 split joined preferences
these prefs : FilterBeforeOverdueReport & DisplayClearScreenButton shouldn't be
lumped together - they do two very different things and have nothing to do with
each other.
this patch splits them into two individual preferences.
Lars Wirzenius [Wed, 2 Jun 2010 05:34:24 +0000 (17:34 +1200)]
Upgrade Koha instance database schema when package is upgraded.
If the new version of Koha requires a newer version of the database
schema, the Koha instances will work immediately after the package
is upgraded, rather than after the sysadmin has run koha-upgrade-schema
manually.
Lars Wirzenius [Fri, 28 May 2010 04:29:48 +0000 (16:29 +1200)]
Add tools to update debian/control's build dependencies.
The canonical list of Perl module dependencies are in
C4::Installer::PerlDependencies::PERL_DEPS now. Add a script
(debian/list-deps) to turn that into a list of Debian package names.
Because that is a slow process, and the output rarely changes, do
not do that at build time. Also, doing it at build time would require
modifying debian/control in evil ways.
Instead, add another tool, debian/update-control, which reads the
new file debian/control.in, and adds the output of debian/list-deps to
Build-Depends and creates a new debian/control.
debian/control.in is the master file. If changes are needed, that should
be edited. For performance and convenience reasons, the output is also kept
in git, but don't edit debian/control directly, please. Such changes
might get lost by the next commit by someone else.
Whenever PERL_DEPS changes, debian/update-control should be run as well
and the result committed to git.
This is not quite as automatic as it might be, but should be good enough.
It avoids keeping the list of Perl modules in two places.
Note that since it seems impossible to automatically figure out the Debian
package version that corresponds to a Perl module version, I have not
tried to do that at all.
Added "dialog alert" class to "No Results Found" message on the patron
search so the alert stands out. Previously no css was applied to it so
it was just plain text. Librarians weren't noticing it.
(MT #2565) fix aqplan csv export, and turn off debug
This fix the csv export that doesn't export correctly the budget name, it's empty column.
And it turn off some SQL debug that slow down the result of the page and the csv export.
projects / koha.git / log