From 1d014b4e3974bec28b7ac12e57d0679b71089b94 Mon Sep 17 00:00:00 2001 From: Colin Campbell Date: Sun, 9 May 2010 15:58:52 +0100 Subject: [PATCH] Do not declare variables within (bogus) conditionals if $index is unnecessary as we have made this true 5 lines above variables should not be declared in conditionals if used outside of them set $struct_attr to a sensible default to avoid generating warnings in this assigment and elsewhere Signed-off-by: Galen Charlton --- C4/Search.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/C4/Search.pm b/C4/Search.pm index 30d8b4fe5a..229ee40e19 100644 --- a/C4/Search.pm +++ b/C4/Search.pm @@ -1123,14 +1123,14 @@ sub buildQuery { } # Set default structure attribute (word list) - my $struct_attr; + my $struct_attr = q{}; unless ( $indexes_set || !$index || $index =~ /(st-|phr|ext|wrdl)/ ) { $struct_attr = ",wrdl"; } # Some helpful index variants - my $index_plus = $index . $struct_attr . ":" if $index; - my $index_plus_comma = $index . $struct_attr . "," if $index; + my $index_plus = $index . $struct_attr . ':'; + my $index_plus_comma = $index . $struct_attr . ','; # Remove Stopwords if ($remove_stopwords) { -- 2.39.5