From eb6ab608d9f2c17064f3ecbcee53a33da3ee5aec Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 19 Aug 2020 07:19:09 +0200 Subject: [PATCH] Bug 26162: Don't fall into an infinite loop If something went wrong we do want to stop the script! Signed-off-by: Jonathan Druart (cherry picked from commit a0b5cefdc88a3671a0310a90490be275bab46860) Signed-off-by: Lucas Gass (cherry picked from commit a29a9ec75408f135e070205fbd1868789b90b54b) --- t/lib/Selenium.pm | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/t/lib/Selenium.pm b/t/lib/Selenium.pm index 7cf5ad26a6..42cda1d65f 100644 --- a/t/lib/Selenium.pm +++ b/t/lib/Selenium.pm @@ -187,7 +187,8 @@ sub show_all_entries { $self->driver->find_element( $xpath_selector . '//div[@class="dataTables_length"]/label/select/option[@value="-1"]' )->click; - my ($all_displayed); + my ($all_displayed, $i); + my $max_retries = $self->max_retries; while ( not $all_displayed ) { my $dt_infos = $self->driver->get_text( $xpath_selector . '//div[@class="dataTables_info"]' ); @@ -197,6 +198,9 @@ sub show_all_entries { } $self->driver->pause(1000) unless $all_displayed; + + die "Cannot show all entries from table $xpath_selector" + if $max_retries <= ++$i } } @@ -216,6 +220,8 @@ sub click_when_visible { $elt->click unless $clicked; # finally Raise the error } +sub max_retries { 10 } + =head1 NAME t::lib::Selenium - Selenium helper module -- 2.39.5