From 6f606e00c597cfdfb30fe969b061a331c8a372db Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Thu, 2 Feb 2023 14:57:14 +0000 Subject: [PATCH] Bug 32797: Check if fields have a value, not if true When saving OAI set mappgins we are checking for truth, this prevents saving subfield 0. We should check for content To test: 1 - Go to Admin->OAI sets 2 - Create a set 3 - Define mappings for the set 4 - Attempt to save a rule on field 952 subfield 0 (withdrawn) 5 - It does not save 6 - Apply patch 7 - Try again 8 - Success! Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Tomas Cohen Arazi --- admin/oai_set_mappings.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/admin/oai_set_mappings.pl b/admin/oai_set_mappings.pl index 02103960f8..a47dadee4a 100755 --- a/admin/oai_set_mappings.pl +++ b/admin/oai_set_mappings.pl @@ -60,7 +60,7 @@ if($op && $op eq "save") { my @mappings; my $i = 0; while($i < @marcfields and $i < @marcsubfields and $i < @marcvalues) { - if($marcfields[$i] and $marcsubfields[$i]) { + if($marcfields[$i] ne '' and $marcsubfields[$i] ne '' ) { push @mappings, { marcfield => $marcfields[$i], marcsubfield => $marcsubfields[$i], -- 2.39.5