From 39ff9705444f8da1ebd82e2093a808c26c503338 Mon Sep 17 00:00:00 2001 From: Eric Garcia Date: Tue, 23 Jul 2024 18:04:41 +0000 Subject: [PATCH] Bug 37435: Fixed renew patron from moremember.pl without circulate permissions To recreate: 1. Have a staff account with limited permissions: -Staff access ( catalouge ) -Add, modify and view patron information (borrowers) -NO circulate permissions 2. Log in as that staff user and find a patron with an expired account. 3. See the warning "Expiration: Patron's card has expired. Renew or Edit details". 4. Try clicking on Renew, you are logged out and see "Error: You do not have permission to access this page." To test: 1. Apply patch 2. From the expired patron's details page see the warning and click Renew 3. Notice it renews the patron and returns to the patron details page 4. Details -> Edit -> Set the expiration date so that the patron is expired 5. Go back to your staff patron and check 'Check out and check in items' permission 6. In your expired patron's page -> Check out -> See warning -> Renew 7. Notice it renews the patron and returns to the check out page 8. Set the expired patron's expiration date so that it expires soon 9. Uncheck 'Check out and check in items' permission for your staff patron 10. Confirm the warning for your patron now is "Expiration: Patron's card expires on (DATE). Renew or Edit details" 11. Repeat steps 2-7 and notice it returns to the correct pages Signed-off-by: Roman Dolny Signed-off-by: Emily Lamancusa Signed-off-by: Martin Renvoize --- .../prog/en/includes/patron_messages.inc | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc index 6c87647b42..1c32d8767e 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron_messages.inc @@ -23,7 +23,11 @@
  • Expiration: Patron's card expires on [% patron.dateexpiry | $KohaDates %]. - Renew or Edit details + [% IF ( moremember ) %] + Renew or Edit details + [% ELSE %] + Renew or Edit details + [% END %]
    • [% END %] @@ -40,7 +44,11 @@ [% IF ( expiry ) %] Patron's card expired on [% expiry | $KohaDates %] [% END %] - Renew or Edit details + [% IF ( moremember ) %] + Renew or Edit details + [% ELSE %] + Renew or Edit details + [% END %] [% END %] -- 2.39.5