]> git.koha-community.org Git - koha.git/commit
Bug 22952: Markup error in OPAC suggestions template
authorOwen Leonard <oleonard@myacpl.org>
Tue, 21 May 2019 16:00:18 +0000 (16:00 +0000)
committerLucas Gass <lucas@bywatersolutions.com>
Tue, 11 Jun 2019 15:03:56 +0000 (15:03 +0000)
commit96aa9338e8fc2e792c27428a5b13d5cc0355ee37
tree9dd98e392c6156f9e1c2562476466870a0b88bd7
parent5a930ccf299c7f7aeeac9d8de185fb1d8d24e9c9
Bug 22952: Markup error in OPAC suggestions template

This patch makes a minor correction to the OPAC suggestions template in
order to quiet an error returned by the HTML validator.

To reproduce the problem you should have the 'suggestion' system
preference turned on, and you should be logged in to the OPAC as a user
who has submitted one or more suggestions. View the "your purchase
suggestions" page in the OPAC. Run the page through the W3C validation
service: https://validator.w3.org. Either by pasting in the URL for the
search results (if web accessible) or by viewing source, copying, and
pasting into "Validate by Direct Input."

This patch specifically addresses these errors:

 - "End tag div seen, but there were open elements."
 - "Unclosed element span."

To test, apply the patch and try again to reproduce the validation
errors. Those errors should no longer be present. There should be no
visible change to the page.

Signed-off-by: Maryse Simard <maryse.simard@inlibro.com>
Signed-off-by: Bin Wen <bin.wen@inlibro.com>
Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com>
Signed-off-by: Arthur Bousquet <arthur.bousquet@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit e72a9c91485c6e68819f3bb76d326f0a1a84dcd9)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit ecfe5811c8b49135b4e0ddee1db5e24d6a854940)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt