]> git.koha-community.org Git - koha.git/commit
Bug 12537: Don't retrieve XISBN results for the same biblionumber
authorNick Clemens <nick@bywatersolutions.com>
Mon, 10 Jun 2019 18:54:30 +0000 (18:54 +0000)
committerLucas Gass <lucas@bywatersolutions.com>
Tue, 6 Aug 2019 04:35:29 +0000 (04:35 +0000)
commit9963687308d14f7a035c499e97263bf8cf56b01e
tree87b51c76a6a7a502aea5171318b5abc59e84041c
parent5dddc0e9a730b15a0a952ee4adf09a9bce4bd76b
Bug 12537: Don't retrieve XISBN results for the same biblionumber

For a biblio with multiple ISBNS we sometimes get our own record back when
check XISBN, we should test for this

To test:
1 - Edit a record in the catalogue, add two isbns:
     0521240670
     0521284198
2 - Enable ThingISBN and FRBRizeEditions and OPACFRBRizeEditions
3 - View the record in staff and OPAC
4 - You should see editions tab pointing to the same record
5 - Apply patch
6 - Reload the record details, you should no longer see editions tab
7 - Add the second ISBN to another record
8 - Reload details for original record, you shoudl see editions linking to the record with second ISBN
9 - prove -v t/db_dependent/XISBN.t

NOTE: Current tests don't work under elasticsearch, but the code does, tests should be rewritten on another bug

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Bouzid Fergani <bouzid.fergani@inlibro.com>
Signed-off-by: Arthur Bousquet <arthur.bousquet@inlibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit fd5686b156ceb10958cab728b7695aa2b39b9933)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 005a799051b38edb1c65070581996654b21a8e87)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
C4/XISBN.pm
catalogue/detail.pl
opac/opac-detail.pl
t/db_dependent/XISBN.t