]> git.koha-community.org Git - koha.git/commit
Bug 18653: Possible privacy breach with OPAC password recovery
authorMarc Véron <veron@veron.ch>
Tue, 23 May 2017 05:08:41 +0000 (07:08 +0200)
committerMason James <mtj@kohaaloha.com>
Sat, 29 Jul 2017 19:09:49 +0000 (07:09 +1200)
commiteda5eb7409002be2b899315b518d05aa768ece43
tree1ddc04ac3ba6f1f029258dc99d927f9d20271376
parenta2b77d876098e791b753e3c9a0164605e0941aa5
Bug 18653: Possible privacy breach with OPAC password recovery

OPAC password recovery allows to find out which email address belongs to an account. An attacker could systematically guess login names. If they hit an existing one, OPAC displays a message like:
An email has been sent to "xxx@yyy.zz".

Having a combination of login name and email, attackers could use the information e.g. for phishing or other personalized actions.

To reproduce:
- Enable OPAC password recovery (syspref OpacResetPassword)
- 'Guess' a login name e.g. by using a common pattern like ptester for Peter Tester
- If such account exists, you get to know the related email address

This patch removes the email address from the success message. Additionaly, it changes
wording to address Bug 18570 ('will be sent' instead of 'has been sent')

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Simplified the wording. "Will be sent shortly" is used elsewhere too.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit eddf975cf0244c731f987c64af5126090f73f9f2)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 2d1dad1a4afa1bfaa14715b7953ed8265dbdb398)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt