From 39bb40f593da37e3f49fa906c3764cdeab589819 Mon Sep 17 00:00:00 2001
From: Fridolin Somers <fridolin.somers@biblibre.com>
Date: Mon, 29 May 2017 16:32:18 +0200
Subject: [PATCH] Bug 18692 - When SMS is enabled the OPAC messaging table is
 misaligned

Bug 6726 had corrected the fact that when SMS is enabled the messaging table is missing a column.
Bug 6458 has broken this.
The SMS column is missing an else case with cell containing only "-" like other columns.

Test plan :
- set SMSSendDriver preference empty
- go to OPAC patron messaging
- column SMS should not be visible
- set SMSSendDriver preference not empty
- go to OPAC patron messaging
- column SMS appears with checkboxes

Signed-off-by: Michael Andrew Cabus <michael@bywatersolutons.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Mason James <mtj@kohaaloha.com>
---
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
index 84cb228130..a653f2dc73 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
@@ -63,8 +63,8 @@
                                         [% ELSE %]
                                             <td>-</td>
                                         [% END %]
-                                        [% IF ( messaging_preference.transport_sms ) %]
-                                            [% IF ( SMSSendDriver ) %]
+                                        [% IF ( SMSSendDriver ) %]
+                                            [% IF ( messaging_preference.transport_sms ) %]
                                                 <td>
                                                     [% IF ( messaging_preference.transports_sms ) %]
                                                       <input type="checkbox" id="sms[% messaging_preference.message_attribute_id %]" name="[% messaging_preference.message_attribute_id %]" value="sms" checked="checked" onclick = "document.opacmessaging.none[% messaging_preference.message_attribute_id %].checked=false;" />
@@ -72,6 +72,8 @@
                                                         <input type="checkbox" id="sms[% messaging_preference.message_attribute_id %]" name="[% messaging_preference.message_attribute_id %]" value="sms" onclick = "document.opacmessaging.none[% messaging_preference.message_attribute_id %].checked=false;" />
                                                     [% END %]
                                                 </td>
+                                            [% ELSE %]
+                                                <td>-</td>
                                             [% END %]
                                         [% END %]
                                         [% IF ( TalkingTechItivaPhone ) %]
-- 
2.39.5