From 7011b3bc84e8ee806e69e947fd6df41bd87e1390 Mon Sep 17 00:00:00 2001
From: Lucas Gass <lucas@bywatersolutions.com>
Date: Fri, 17 Nov 2023 21:39:02 +0000
Subject: [PATCH] Bug 35356: Show SMS labels only when data exists

To test:
APPLY PATCH
1. Set SMSSendDriver = Email
2. Admin > SMS cellular providers, have at least 1.
3. Go to the members/moremember.pl
4. If the patron has no SMSnumber or SMS provider then niether of the labels should appear.
5. Add both a SMSnumber and SMS provider, make sure the data appears correctly on members/moremember.pl.

Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 756a9311a15c2748d0c330540e1e3d38a43448e5)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
---
 .../prog/en/modules/members/moremember.tt            | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
index 3a1278e3cf..095c6e35dc 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
@@ -354,11 +354,13 @@
                                     [% IF Koha.Preference('SMSSendDriver') %]
                                         <div class="rows">
                                             <ol>
-                                                <li>
-                                                    <span class="label">SMS number:</span>
-                                                    <a href="sms:[% patron.smsalertnumber | uri %]">[% patron.smsalertnumber | html %]</a>
-                                                </li>
-                                                [% IF Koha.Preference( 'SMSSendDriver') == 'Email' %]
+                                                [% IF patron.smsalertnumber %]
+                                                    <li>
+                                                        <span class="label">SMS number:</span>
+                                                        <a href="sms:[% patron.smsalertnumber | uri %]">[% patron.smsalertnumber | html %]</a>
+                                                    </li>
+                                                [% END %]
+                                                [% IF Koha.Preference( 'SMSSendDriver') == 'Email' && patron.sms_provider.name %]
                                                 <li>
                                                     <span class="label">SMS provider:</span>
                                                     [% patron.sms_provider.name | html %]
-- 
2.39.5