From 70681a47f2cefcdee665d4d8076f3228eee891de Mon Sep 17 00:00:00 2001 From: Colin Campbell Date: Wed, 14 Aug 2013 15:26:34 +0100 Subject: [PATCH] Bug 10728: fix log noise generated by subscription-renew.pl Error log is showing warnings because mode is undefined and we are doing string comparisons on it. Set it to a default value (we were already assigning it a variable which we were not using) and use the the result in the comparison To test, after applying the patch: [1] Use the renew link from the subscription detail page to renew a subscription. [2] Verifying that doing this did not add a warning containing 'subscription-renew.pl: Use of uninitialized value $mode in string eq ' to the Apache error log. Signed-off-by: Galen Charlton Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit 27edb618dd604e0a718f43e98ed97255f72eb515) Signed-off-by: Tomas Cohen Arazi --- serials/subscription-renew.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/serials/subscription-renew.pl b/serials/subscription-renew.pl index 48861bcae4..47b35f0177 100755 --- a/serials/subscription-renew.pl +++ b/serials/subscription-renew.pl @@ -59,7 +59,7 @@ use C4::Serials; my $query = new CGI; my $dbh = C4::Context->dbh; -my $mode = $query->param('mode'); +my $mode = $query->param('mode') || q{}; my $op = $query->param('op') || q{}; my $subscriptionid = $query->param('subscriptionid'); my $done = 0; # for after form has been submitted @@ -99,7 +99,7 @@ $template->param( subscriptionid => $subscriptionid, bibliotitle => $subscription->{bibliotitle}, $op => 1, - popup => ($query->param('mode')eq "popup"), + popup => ($mode eq 'popup'), ); # Print the page -- 2.39.5