From 96650b4e76a5bc1302611a3a150e195e85e6f8fa Mon Sep 17 00:00:00 2001 From: Mason James Date: Tue, 2 May 2017 17:26:09 +1200 Subject: [PATCH] Revert "Bug 18094: Add tests to highlight the problem" This reverts commit dde4036df4fba9b8d3652a78c320c42f9e71c660. --- t/db_dependent/Utils/Datatables_Members.t | 31 +---------------------- 1 file changed, 1 insertion(+), 30 deletions(-) diff --git a/t/db_dependent/Utils/Datatables_Members.t b/t/db_dependent/Utils/Datatables_Members.t index 02561e4112..4b9ab93b98 100644 --- a/t/db_dependent/Utils/Datatables_Members.t +++ b/t/db_dependent/Utils/Datatables_Members.t @@ -17,7 +17,7 @@ use Modern::Perl; -use Test::More tests => 30; +use Test::More tests => 29; use C4::Context; use C4::Members; @@ -296,9 +296,6 @@ C4::Members::Attributes::SetBorrowerAttributes( C4::Members::Attributes::SetBorrowerAttributes( $jane_doe{borrowernumber}, [ { code => $attribute_type->{code}, value => 'the default value for another common user' } ] ); -C4::Members::Attributes::SetBorrowerAttributes( - $john_smith->{borrowernumber}, [ { code => $attribute_type->{code}, value => 'Attribute which not appears even if contains "Dupont"' } ] -); t::lib::Mocks::mock_preference('ExtendedPatronAttributes', 1); $search_results = C4::Utils::DataTables::Members::search({ @@ -382,32 +379,6 @@ $search_results = C4::Utils::DataTables::Members::search({ is( $search_results->{ iTotalDisplayRecords }, 1, "Sarching by date of birth should handle date formatted in iso"); -subtest 'ExtendedPatronAttributes' => sub { - plan tests => 2; - t::lib::Mocks::mock_preference('ExtendedPatronAttributes', 1); - $search_results = C4::Utils::DataTables::Members::search({ - searchmember => "Dupont", - searchfieldstype => 'standard', - searchtype => 'contain', - branchcode => $branchcode, - dt_params => \%dt_params - }); - - is( $search_results->{ iTotalDisplayRecords }, 3, - "'Dupont' is contained in 2 surnames and a patron attribute. Patron attribute one should be displayed if searching in all fields (Bug 18094)"); - - $search_results = C4::Utils::DataTables::Members::search({ - searchmember => "Dupont", - searchfieldstype => 'surname', - searchtype => 'contain', - branchcode => $branchcode, - dt_params => \%dt_params - }); - - is( $search_results->{ iTotalDisplayRecords }, 1, - "'Dupont' is contained in 2 surnames and a patron attribute. Patron attribute one should not be displayed if searching in specific fields (Bug 18094)"); -}; - # End $dbh->rollback; -- 2.39.5