From d453bb9c5d21814054f0c19db86893b91d11fdf5 Mon Sep 17 00:00:00 2001
From: Katrin Fischer <katrin.fischer.83@web.de>
Date: Mon, 10 Apr 2023 16:08:32 +0000
Subject: [PATCH] Bug 29311: (follow-up) Add id to span elements

The input fields in the form have ids, these are useful
for styling, but also for the Selenium tests. This patch
adds the ids from the former inputs to the now spans.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 2fc06098d2133bfc7c46701e0e90fc384bbb1342)
Signed-off-by: Jacob O'Mara <jacobomara901@gmail.com>
(cherry picked from commit f88186b34511ee21d50dc4727cf217f2bb85e0a1)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
---
 .../bootstrap/en/modules/opac-suggestions.tt       | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
index 552fe49c28..8d366050ea 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
@@ -86,7 +86,7 @@
                                         <li>
                                             [% IF biblionumber %]
                                                 <label>Title:</label>
-                                                <a href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% biblionumber | uri %]">[% title | html %]</a>
+                                                <a id="title" href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% biblionumber | uri %]">[% title | html %]</a>
                                             [% ELSIF ( title_required ) %]
                                                 <label for="title" class="required">Title:</label>
                                                 <input type="text" id="title" name="title" class="span6" maxlength="255" value="[% title | html %]" required="required" />
@@ -100,7 +100,7 @@
                                             <li>
                                                     [% IF biblionumber %]
                                                         <label>Author:</label>
-                                                        <span>[% author | html %]</span>
+                                                        <span id="author">[% author | html %]</span>
                                                     [% ELSIF ( author_required ) %]
                                                         <label for="author" class="required">Author:</label>
                                                         <input type="text" id="author" name="author" class="span6" maxlength="80" value="[% author | html %]" required="required" />
@@ -116,7 +116,7 @@
                                                 <div title="Copyright or publication year, for example: 2022">
                                                     [% IF biblionumber %]
                                                         <label>Publication year:</label>
-                                                        <span>[% copyrightdate | html %]</span>
+                                                        <span id="copyrightdate">[% copyrightdate | html %]</span>
                                                     [% ELSIF ( copyrightdate_required ) %]
                                                         <label for="copyrightdate" class="required">Publication year:</label>
                                                         <input type="text" id="copyrightdate" name="copyrightdate" pattern="[12]\d{3}" size="10" maxlength="4" value="[% copyrightdate | html %]" required="required" />
@@ -134,7 +134,7 @@
                                             <li>
                                                 [% IF biblionumber %]
                                                     <label>Standard number (ISBN, ISSN or other):</label>
-                                                    <span>[% isbn | html %]</span>
+                                                    <span id="isbn">[% isbn | html %]</span>
                                                 [% ELSIF ( isbn_required ) %]
                                                     <label for="isbn" class="required">Standard number (ISBN, ISSN or other):</label>
                                                     <input type="text" id="isbn" name="isbn"  maxlength="80" value="[% isbn | html %]" required="required" />
@@ -149,7 +149,7 @@
                                             <li>
                                                 [% IF biblionumber %]
                                                     <label>Publisher:</label>
-                                                    <span>[% publishercode | html %]</span>
+                                                    <span id="publishercode">[% publishercode | html %]</span>
                                                 [% ELSIF ( publishercode_required ) %]
                                                     <label for="publishercode" class="required">Publisher:</label>
                                                     <input type="text" id="publishercode" name="publishercode" class="span6" maxlength="80" value="[% publishercode | html %]" required="required" />
@@ -164,7 +164,7 @@
                                             <li>
                                                 [% IF biblionumber %]
                                                     <label for="collectiontitle" class="required">Collection title:</label>
-                                                    <span>[% collectiontitle | html %]</span>
+                                                    <span id="collectiontitle">[% collectiontitle | html %]</span>
                                                 [% ELSIF ( collectiontitle_required ) %]
                                                     <label for="collectiontitle" class="required">Collection title:</label>
                                                     <input type="text" id="collectiontitle" name="collectiontitle" class="span6" maxlength="80" value="[% collectiontitle | html %]" required="required" />
@@ -179,7 +179,7 @@
                                             <li>
                                                 [% IF biblionumber %]
                                                     <label for="place" class="required">Publication place:</label>
-                                                    <span>[% place | html %]</span>
+                                                    <span id="place">[% place | html %]</span>
                                                 [% ELSIF ( place_required ) %]
                                                     <label for="place" class="required">Publication place:</label>
                                                     <input type="text" id="place" name="place" required="required" maxlength="80" value="[% place | html %]" />
-- 
2.39.5