From ecc3d1957fa979dec98f518921f0895a6adb84ac Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Thu, 21 May 2020 13:52:32 -0400 Subject: [PATCH] Bug 25537: Page reload at branchtransfers.pl loses destination branch At branchtransfers.pl, one selects a destination branch and scans in any number of items to generate transfers to that branch. However, anything that makes the page reload causes your branch selection to be lost, reverting you back to whichever branch comes first alphabetically. This is an invitation to error when one has a stack of books to send all to the same branch. Could that error handling get moved into a modal or something that won't reload the page? Test Plan: 1) Place a hold on an item and set it to waiting 2) Initiate a branch transfer from branchtransfers.pl for any branch but the first in the pulldown branch selector 3) Choose to cancel the hold and transfer 4) Note the pulldown reverts to the first option 5) Apply this patch 6) Repeat steps 1-3 7) Note the pulldown retains your preveiously selected branch! Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart (cherry picked from commit 8ab8df3866352568509ed34f02a5566e750dee21) Signed-off-by: Lucas Gass (cherry picked from commit c8c394d1704acab20717ac3939ee1e5d45343e92) Signed-off-by: Aleisha Amohia (cherry picked from commit 9402b7c24cac53003f5ddb22b021d10016e4f2c1) Signed-off-by: Victor Grousset/tuxayo --- koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt | 1 + 1 file changed, 1 insertion(+) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt index 3e7f9e936f..9b3f6a2793 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt @@ -46,6 +46,7 @@ [% END %] + [% IF ( waiting ) %] -- 2.39.5