From 1bc3bbfdc78bfd559fec841c6ca47ddcbeb0f179 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 11 May 2018 11:33:32 +0200 Subject: [PATCH] Bug 20623: (QA follow-up) Remove one find call Imo these somewhat weird lines ask for improvement, but I don't want to change the exact conditions here. Just removing the need to call find twice. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart --- acqui/basketgroup.pl | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/acqui/basketgroup.pl b/acqui/basketgroup.pl index 386357b207..92a58ac2cb 100755 --- a/acqui/basketgroup.pl +++ b/acqui/basketgroup.pl @@ -194,10 +194,9 @@ sub printbasketgrouppdf{ } } - my $item_has_type_description = ($ord->{itemtype} - and $biblioitem->itemtype - and Koha::ItemTypes->find( $biblioitem->itemtype )); - $ord->{itemtype} = $item_has_type_description ? Koha::ItemTypes->find( $biblioitem->itemtype )->description : undef; + my $itemtype = Koha::ItemTypes->find( $biblioitem->itemtype ); + my $item_has_type_description = $ord->{itemtype} && $biblioitem->itemtype && $itemtype; + $ord->{itemtype} = $item_has_type_description ? $itemtype->description : undef; $ord->{en} = $en ? $en : undef; $ord->{edition} = $edition ? $edition : undef; -- 2.39.5