From 99013d6896fc591a7733568bcb7044cad399a7c5 Mon Sep 17 00:00:00 2001 From: Katrin Fischer Date: Thu, 1 Nov 2018 13:01:48 +0000 Subject: [PATCH] Bug 21796: Don't unlock checkouts if restriction exists but fines are below limit The checkout form will be removed if various conditions are met: Restrictions, a fine above noissuescharge etc. Bug 19933 changed the conditions, so a restriction will no longer block checkouts, if the fines are below the set limit. To test: - Add a restriction - Confirm the checkouts form is replaced by a message - Add a fine below the noissuescharge limit - Confirm that the form reappears - Apply the patch - Check that the checkout form is gone now - Remove restriction - form should reappear - Add to the fine, so it's above the limit - Form should disappear Signed-off-by: Pierre-Marc Thibault Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens --- circ/circulation.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/circ/circulation.pl b/circ/circulation.pl index 5c858f717c..98b011bd11 100755 --- a/circ/circulation.pl +++ b/circ/circulation.pl @@ -487,7 +487,7 @@ if ( $patron ) { my $account = $patron->account; if( ( my $owing = $account->non_issues_charges ) > 0 ) { my $noissuescharge = C4::Context->preference("noissuescharge") || 5; # FIXME If noissuescharge == 0 then 5, why?? - $noissues = ( not C4::Context->preference("AllowFineOverride") and ( $owing > $noissuescharge ) ); + $noissues ||= ( not C4::Context->preference("AllowFineOverride") and ( $owing > $noissuescharge ) ); $template->param( charges => 1, chargesamount => $owing, -- 2.39.5