From c5954d5e946a53661e330514358db566b6e69022 Mon Sep 17 00:00:00 2001
From: Josef Moravec <josef.moravec@gmail.com>
Date: Tue, 2 Jan 2018 06:35:47 +0000
Subject: [PATCH] Bug 19902: Add column settings to bibliographic record
 checkouts history table

Test plan:
0) Apply the patch
1) Go to administration -> Configure columns, note there is new
checkoutshistory-table in Catalogue section
2) Make some configuration in this table settings
3) Go to detail of any record -> Checkout history
4) The columns should be visible according to your configuration from
step 2
5) Play with Column visibility, to ensure it does work as it should

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Fixed a minor typo during signoff.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
---
 admin/columns_settings.yml                    | 22 +++++++++++++++++++
 .../prog/en/modules/catalogue/issuehistory.tt |  8 +++++--
 2 files changed, 28 insertions(+), 2 deletions(-)

diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml
index 8f0628f06d..6f7022db6b 100644
--- a/admin/columns_settings.yml
+++ b/admin/columns_settings.yml
@@ -83,6 +83,28 @@ modules:
         -
           columnname: actions
 
+  catalogue:
+    detail:
+      checkoutshistory-table:
+        -
+          columnname: patron
+          cannot_be_toggled: 1
+          cannot_be_modified: 1
+        -
+          columnname: barcode
+          cannot_be_toggled: 1
+          cannot_be_modified: 1
+        -
+          columnname: checked_out_from
+        -
+          columnname: renewed
+        -
+          columnname: checkout_on
+        -
+          columnname: due_date
+        -
+          columnname: checkin_on
+
   cataloguing:
     additem:
       itemst:
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt
index 785857a094..3900344f86 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt
@@ -2,6 +2,7 @@
 [% USE Koha %]
 [% USE KohaDates %]
 [% USE Branches %]
+[% USE ColumnsSettings %]
 [% SET footerjs = 1 %]
 [% INCLUDE 'doc-head-open.inc' %]
 <title>Koha &rsaquo; Catalog &rsaquo; Checkout history for [% biblio.title |html %]</title>
@@ -98,15 +99,18 @@
 
 [% MACRO jsinclude BLOCK %]
 [% INCLUDE 'datatables.inc' %]
+[% INCLUDE 'columns_settings.inc' %]
     <script type="text/javascript" id="js">
         $(document).ready(function() {
-            $("#table_issues").dataTable($.extend(true, {}, dataTablesDefaults, {
+            var columns_settings = [% ColumnsSettings.GetColumns('catalogue', 'detail', 'checkoutshistory-table', 'json') %];
+            var table = KohaTable("table_issues", {
                 "aoColumnDefs": [
                     { "sType": "title-string", "aTargets" : [ "title-string" ] }
                 ],
+                "sDom": 'C<"top pager"ilpfB><"#filter_c">tr<"bottom pager"ip>',
                 "aaSorting": [[ 4, "desc" ]],
                 "sPaginationType": "full_numbers"
-            }));
+            }, columns_settings);
         });
     </script>
 [% END %]
-- 
2.39.5