From ffd7365d86edc2dd0f9a00921d6640450f09fdfb Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Mon, 4 Jun 2018 14:40:03 +0000 Subject: [PATCH] Bug 20876: The form_serialized_itype cookie is not used and should be removed This patch removes references to a form_serialized_itype cookie which appears in the code as part of the process of storing information used in the generation of the "Return to the last advanced search" link. To test, apply the patch and perform an advanced search in the OPAC using several search options including a limit by item type. From the search results page, follow the "Return to the last advanced search" link. The advanced search form should appear with all the search options you submitted before. Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize (cherry picked from commit 3b9a81e394c4f47433b3f0057b9b819549f583b8) Signed-off-by: Fridolin Somers --- koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc | 1 - koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt | 1 - 2 files changed, 2 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc index 834669144d..e717b391dc 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc +++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc @@ -246,7 +246,6 @@ $(document).ready(function() { if($('#searchsubmit').length) { $(document).on("click", '#searchsubmit', function(e) { jQuery.removeCookie("form_serialized", { path: '/'}); - jQuery.removeCookie("form_serialized_itype", { path: '/'}); jQuery.removeCookie("form_serialized_limits", { path: '/'}); jQuery.removeCookie("num_paragraph", { path: '/'}); jQuery.removeCookie("search_path_code", { path: '/'}); diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt index 421f91efbd..46e4ab4ede 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt @@ -420,7 +420,6 @@ $(document).ready(function() { [% ELSE %] //Clear all form cookies jQuery.removeCookie("form_serialized", { path: '/'}); - jQuery.removeCookie("form_serialized_itype", { path: '/'}); jQuery.removeCookie("form_serialized_limits", { path: '/'}); jQuery.removeCookie("num_paragraph", { path: '/'}); jQuery.removeCookie("search_path_code", { path: '/'}); -- 2.39.5