From 884cd85201fdc90dfd26c69f1d3808e20f580184 Mon Sep 17 00:00:00 2001
From: Katrin Fischer <katrin.fischer@bsz-bw.de>
Date: Fri, 25 Oct 2024 14:30:12 +0000
Subject: [PATCH] Bug 38222: (QA follow-up) Fix translation and capitalization
 issues

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
---
 .../en/includes/modals/cancel_booking.inc     |  2 +-
 .../prog/en/modules/bookings/list.tt          | 26 +++++++++----------
 .../intranet-tmpl/prog/js/tables/bookings.js  | 12 ++++-----
 3 files changed, 20 insertions(+), 20 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/modals/cancel_booking.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/modals/cancel_booking.inc
index 989f7a09ad..f5c2a8a102 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/modals/cancel_booking.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/modals/cancel_booking.inc
@@ -15,7 +15,7 @@
                     <fieldset class="brief">
                         [% SET booking_cancellation = AuthorisedValues.GetAuthValueDropbox('BOOKING_CANCELLATION') %]
                         <div class="combobox-container">
-                            <label for="cancellation-reason" class="form-label">Cancellation Reason:</label>
+                            <label for="cancellation-reason" class="form-label">Cancellation reason:</label>
                             <input type="text" id="cancellation-reason" name="cancellation_reason" class="form-control" maxlength="80" />
                             <ul id="cancellation-reason-list" class="dropdown-menu">
                                 [% IF booking_cancellation.count %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt
index 979ed7ac43..95e4f67f8c 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt
@@ -281,37 +281,37 @@
                     const statusMap = {
                         new: () => {
                             if (isExpired(row.end_date)) {
-                                return __("Expired");
+                                return _("Expired");
                             }
 
                             if (isActive(row.start_date, row.end_date)) {
-                                return __("Active");
+                                return _("Active");
                             }
 
                             if (dayjs(row.start_date).isAfter(new Date())) {
-                                return __("Pending");
+                                return _("Pending");
                             }
 
-                            return __("New");
+                            return _("New");
                         },
                         cancelled: () =>
-                            [__("Cancelled"), row.cancellation_reason]
+                            [_("Cancelled"), row.cancellation_reason]
                                 .filter(Boolean)
                                 .join(": "),
-                        completed: () => __("Completed"),
+                        completed: () => _("Completed"),
                     };
 
                     const statusText = statusMap[row.status]
                         ? statusMap[row.status]()
-                        : __("Unknown");
+                        : _("Unknown");
 
                     const classMap = [
-                        { status: __("Expired"), class: "bg-secondary" },
-                        { status: __("Cancelled"), class: "bg-secondary" },
-                        { status: __("Pending"), class: "bg-warning" },
-                        { status: __("Active"), class: "bg-primary" },
-                        { status: __("Completed"), class: "bg-info" },
-                        { status: __("New"), class: "bg-success" },
+                        { status: _("Expired"), class: "bg-secondary" },
+                        { status: _("Cancelled"), class: "bg-secondary" },
+                        { status: _("Pending"), class: "bg-warning" },
+                        { status: _("Active"), class: "bg-primary" },
+                        { status: _("Completed"), class: "bg-info" },
+                        { status: _("New"), class: "bg-success" },
                     ];
 
                     const badgeClass =
diff --git a/koha-tmpl/intranet-tmpl/prog/js/tables/bookings.js b/koha-tmpl/intranet-tmpl/prog/js/tables/bookings.js
index 018ffdffb8..0a99991773 100644
--- a/koha-tmpl/intranet-tmpl/prog/js/tables/bookings.js
+++ b/koha-tmpl/intranet-tmpl/prog/js/tables/bookings.js
@@ -161,12 +161,12 @@ $(document).ready(function () {
             : __("Unknown");
 
         const classMap = [
-            { status: _("Expired"), class: "bg-secondary" },
-            { status: _("Cancelled"), class: "bg-secondary" },
-            { status: _("Pending"), class: "bg-warning" },
-            { status: _("Active"), class: "bg-primary" },
-            { status: _("Completed"), class: "bg-info" },
-            { status: _("New"), class: "bg-success" },
+            { status: __("Expired"), class: "bg-secondary" },
+            { status: __("Cancelled"), class: "bg-secondary" },
+            { status: __("Pending"), class: "bg-warning" },
+            { status: __("Active"), class: "bg-primary" },
+            { status: __("Completed"), class: "bg-info" },
+            { status: __("New"), class: "bg-success" },
         ];
 
         const badgeClass =
-- 
2.39.5