From d19784f6a57f10eeb964255359ae97da90faf2b3 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Fri, 6 Aug 2021 11:46:12 +0000 Subject: [PATCH] Bug 7703: (QA follow-up) Revised test plan from Owen: This patch modifies the hold process so that if one of the titles in a multi-hold process has no items the process doesn't abort completely. To test, apply the patch and perform a search in the catalog which will return one or more records with no items attached. - Check checkboxes for multiple results, some of which have items and at least one of which has no items. - Click "Place hold." - You should be taken to the page for placing multiple holds, with a heading, "Cannot place hold on some items." - Note: You will not be able to complete the holds process without the next patch. Signed-off-by: Owen Leonard Signed-off-by: Sally Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart --- koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 6 +++--- reserve/request.pl | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt index 4d8266483d..2e5fbeaf1c 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ -864,12 +864,12 @@
[% IF ( patron AND patron.borrowernumber ) %] [% IF ( override_required ) %] - + [% ELSIF ( none_available ) %] - + [% ELSE %] [% IF ( multi_hold ) %] - + [% ELSE %] [% END %] diff --git a/reserve/request.pl b/reserve/request.pl index 2dab6e37d0..6ab8ba7ac5 100755 --- a/reserve/request.pl +++ b/reserve/request.pl @@ -403,7 +403,7 @@ foreach my $biblionumber (@biblionumbers) { unless ( $items->count ) { # FIXME Then why do we continue? - $template->param('noitems' => 1); + $template->param('noitems' => 1) unless ( $multi_hold ); $biblioloopiter{noitems} = 1; } -- 2.39.5