]> git.koha-community.org Git - koha.git/commit
Bug 15773: Fix and standardise checkboxes code in framework
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 9 Feb 2016 17:02:05 +0000 (17:02 +0000)
committerBrendan Gallagher <brendan@bywatersolutions.com>
Wed, 23 Mar 2016 01:06:55 +0000 (01:06 +0000)
commit39597b86ae299a9b4c0c1e8221f51f9e8dd300ed
treed22f9d0703c45b766c18746b00f33d3a7d9d913b
parent6a078fb1b34ad9585ccd4c717723dfca2a91df80
Bug 15773: Fix and standardise checkboxes code in framework

When creating a new subfield for an authority framework, the checkboxes
don't behave as they should.
If you click on the 'repeatable', 'mandatory' or 'is url' checkbox's
label, the checkbox from the second tab will be checked/unchecked.
This is caused by a non-unique id of the input element.

I have found this bug when working on the removal of CGI::checkbox in
both admin/auth_subfields_structure.pl and
admin/marc_subfields_structure.pl scripts.

This patch remove the use of CGI::checkbox as well as the generation of
html code from these 2 pl scripts (which should be avoided).
The code these scripts are now pretty similar.

Test plan:
Add/modify/remove subfield for a MARC framework and an Authority
framework.
Use as many field as possible and confirm that the values are correctly
inserted/displayed.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
admin/auth_subfields_structure.pl
admin/marc_subfields_structure.pl
koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt
koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt